Fix #55422: Buffer.concat and Buffer.copy silently produce invalid r#61914
Open
danielalanbates wants to merge 1 commit intonodejs:mainfrom
Open
Fix #55422: Buffer.concat and Buffer.copy silently produce invalid r#61914danielalanbates wants to merge 1 commit intonodejs:mainfrom
Buffer.concat and Buffer.copy silently produce invalid r#61914danielalanbates wants to merge 1 commit intonodejs:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61914 +/- ##
==========================================
- Coverage 91.70% 89.65% -2.06%
==========================================
Files 337 676 +339
Lines 140104 206549 +66445
Branches 21758 39544 +17786
==========================================
+ Hits 128484 185172 +56688
- Misses 11398 13480 +2082
- Partials 222 7897 +7675
🚀 New features to boost your workflow:
|
Renegade334
reviewed
Feb 21, 2026
Author
|
Thanks for the feedback, @Renegade334! I've pushed an update addressing your review comments. Please take another look when you get a chance. |
Member
|
Mostly good, modulo:
|
Member
|
@danielalanbates are you able to address the above comments? |
Buffer.copy silently produced incorrect results when indices involved were >= 2^32 due to 32-bit integer overflow in the native SlowCopy and FastCopy functions in node_buffer.cc. Change the parameter types and return type of SlowCopy and FastCopy from uint32_t to uint64_t so that offsets beyond 4 GiB are handled correctly. Fixes: nodejs#55422
723a5cc to
6ac2ab5
Compare
Renegade334
approved these changes
Mar 9, 2026
This comment has been minimized.
This comment has been minimized.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #55422
Summary
This PR fixes:
Buffer.concatandBuffer.copysilently produce invalid results when the operation involves indices equal or greater than 2^32Changes
Testing
Please review the changes carefully. The fix was verified against the existing test suite.
This PR was created with the assistance of Claude Sonnet 4.6 by Anthropic | effort: high. Happy to make any adjustments!