Skip to content

doc: clarify fs.copyFile() symlink behavior#61669

Open
junnyontop-pixel wants to merge 1 commit intonodejs:mainfrom
junnyontop-pixel:doc-copyfile-symlink
Open

doc: clarify fs.copyFile() symlink behavior#61669
junnyontop-pixel wants to merge 1 commit intonodejs:mainfrom
junnyontop-pixel:doc-copyfile-symlink

Conversation

@junnyontop-pixel
Copy link
Contributor

@junnyontop-pixel junnyontop-pixel commented Feb 4, 2026

This PR documents that fs.copyFile() always dereferences symbolic links, as requested in #61518.

When src is a symbolic link, the contents of the target file are copied instead of the link itself.

Fixes: #61518

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 4, 2026
@junnyontop-pixel
Copy link
Contributor Author

junnyontop-pixel commented Feb 4, 2026

Sorry, I accidentally included a README change from my main branch. I will fix this PR to only include fs.md changes.

@Renegade334
Copy link
Member

Renegade334 commented Feb 11, 2026

Please can you squash your commits, so that doc: clarify fs.copyFile() symlink behavior is the commit message that appears in the final changelog.

@junnyontop-pixel junnyontop-pixel force-pushed the doc-copyfile-symlink branch 2 times, most recently from 43c94a9 to d7f81cb Compare February 11, 2026 02:57
@junnyontop-pixel
Copy link
Contributor Author

junnyontop-pixel commented Feb 11, 2026

I've squashed the commits into one and fixed the trailing whitespace issue. The commit message has also been updated as you requested. Thanks!

@junnyontop-pixel
Copy link
Contributor Author

junnyontop-pixel commented Feb 15, 2026

Hi @Renegade334, I've completed all the requested changes. Could you please take another look when you have a moment? Thanks!

@junnyontop-pixel
Copy link
Contributor Author

junnyontop-pixel commented Feb 15, 2026

Sorry, I closed and reopened this PR by mistake.

Renegade334
Renegade334 requested changes Feb 15, 2026
View reviewed changes
Copy link
Member

@Renegade334 Renegade334 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just needs a quick layout edit.

@junnyontop-pixel
Copy link
Contributor Author

junnyontop-pixel commented Feb 21, 2026

Hi @Renegade334, I've moved the note to the position you suggested and force-pushed the update. Could you please take a look when you have a chance? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renegade334 Renegade334 Renegade334 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document that fs.copyFile() dereferences symlinks

3 participants

@junnyontop-pixel @Renegade334 @nodejs-github-bot