Skip to content

quic: move quic behind compile time flag #61444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mcollina wants to merge 1 commit into
base: main
Choose a base branch
from
Open

quic: move quic behind compile time flag #61444

mcollina wants to merge 1 commit into from

Conversation

@mcollina
Copy link
Member

@mcollina mcollina commented Jan 19, 2026

Move node:quic behind a compile-time flag, disabled by default. Use --experimental-quic at configure time to enable.

  • Add --experimental-quic flag to configure.py
  • Add node_use_quic variable and HAVE_QUIC define
  • Make QUIC sources conditional in node.gyp
  • Move ngtcp2/nghttp3 deps under QUIC condition in node.gypi
  • Update C++ guards to check HAVE_QUIC
  • Update process.features.quic to check node_use_quic

@mcollina
quic: move quic behind compile time flag
c1277d6 
Move node:quic behind a compile-time flag, disabled by default.
Use --experimental-quic at configure time to enable.

- Add --experimental-quic flag to configure.py
- Add node_use_quic variable and HAVE_QUIC define
- Make QUIC sources conditional in node.gyp
- Move ngtcp2/nghttp3 deps under QUIC condition in node.gypi
- Update C++ guards to check HAVE_QUIC
- Update process.features.quic to check node_use_quic
@mcollina mcollina requested a review from jasnell January 19, 2026 17:12
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 19, 2026

Review requested:

  • @nodejs/gyp
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 19, 2026
@mcollina
Copy link
Member Author

mcollina commented Jan 19, 2026

@jasnell to which version this should be backported to?

@mcollina mcollina requested a review from aduh95 January 19, 2026 17:14
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 19, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70892/

@codecov
Copy link

codecov bot commented Jan 19, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.85%. Comparing base (637bda0) to head (c1277d6).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/bootstrap/node.js 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61444      +/-   ##
==========================================
+ Coverage   88.51%   89.85%   +1.34%     
==========================================
  Files         704      671      -33     
  Lines      208883   203055    -5828     
  Branches    40334    39046    -1288     
==========================================
- Hits       184890   182465    -2425     
+ Misses      15977    12931    -3046     
+ Partials     8016     7659     -357
Files with missing lines Coverage Δ
lib/internal/bootstrap/node.js 98.96% <0.00%> (-0.63%) ⬇️

... and 90 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

khanbilal732
khanbilal732 reviewed Jan 19, 2026
View reviewed changes
Copy link

@khanbilal732 khanbilal732 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 19, 2026
@aduh95 aduh95 mentioned this pull request Jan 19, 2026
Open
@richardlau
Copy link
Member

richardlau commented Jan 20, 2026

@jasnell to which version this should be backported to?

AFAIK the quic stuff has been mostly labelled dont-land-on-v24.x and earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@aduh95 aduh95 aduh95 approved these changes

@trivikr trivikr trivikr approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@avivkeller avivkeller avivkeller approved these changes

+2 more reviewers

@khanbilal732 khanbilal732 khanbilal732 left review comments

@aymen94 aymen94 aymen94 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@mcollina @nodejs-github-bot @richardlau @jasnell @aymen94 @aduh95 @trivikr @RafaelGSS @avivkeller @khanbilal732