-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
fix: custom inspect should not throw when called with wrong this #61128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 4 commits into
nodejs:main
from
efekrskl:fix/remove-eventtarget-custom-inspect-branding
Dec 22, 2025
+19
−2
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d3edbd1
events: remove eventtarget custom inspect branding
efekrskl 830ace5
test: test eventtarget custom inspect w/o branding
efekrskl bf43b8a
test: use check output type instead of using doesNotThrow
efekrskl d8e55f9
test: fix lint errors
efekrskl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
test/parallel/test-eventtarget-custom-inspect-does-not-throw.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| 'use strict'; | ||
|
|
||
| const assert = require('assert'); | ||
| const util = require('util'); | ||
|
|
||
| const symbol = util.inspect.custom; | ||
|
|
||
| const eventTargetInspect = EventTarget.prototype[symbol]; | ||
|
|
||
| const fakeEventTarget = { | ||
| [symbol]: eventTargetInspect, | ||
| someOtherField: 42 | ||
| }; | ||
|
|
||
| assert.doesNotThrow(() => { | ||
| util.inspect(fakeEventTarget); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.