More commit queue fixes - #1158
Merged
Merged
Conversation
Filter check suites by the GitHub Actions App ID rather than requesting App metadata for every suite, which GITHUB_TOKEN cannot access for third-party Apps. Assisted-by: codex:gpt-5.6-sol Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Preserve all GraphQL errors and render their structured data as JSON so paths, locations, extensions, and additional errors remain visible in command logs. Assisted-by: codex:gpt-5.6-sol Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1158 +/- ##
==========================================
+ Coverage 57.17% 57.49% +0.31%
==========================================
Files 53 53
Lines 10394 10396 +2
==========================================
+ Hits 5943 5977 +34
+ Misses 4451 4419 -32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
aduh95
reviewed
Aug 10, 2026
| # querying App metadata that GITHUB_TOKEN cannot read for suites | ||
| # created by third-party Apps such as Jenkins and Codecov. | ||
| # https://api.github.com/apps/github-actions | ||
| checkSuites(first: 100, filterBy: { appId: 15368 }) { |
Contributor
There was a problem hiding this comment.
This should solve the issue of phantom Jenkins jobs, right?
Member
Author
There was a problem hiding this comment.
I don't think so, but it's possible?. We still process the same suites as before downstream because we used to filter by app.slug amongst the results, now we just filter by the appId behind that slug server side.
aduh95
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter check suites by the GitHub Actions App ID rather than requesting App metadata for every suite and checking a slug.
Preserve all GraphQL errors and render their structured data as JSON.
Assisted-by: codex:gpt-5.6-sol