Skip to content

add clang-format#112

Merged
gengjiawen merged 1 commit into
nodejs:masterfrom
gengjiawen:feature/clang-format
Sep 6, 2019
Merged

add clang-format#112
gengjiawen merged 1 commit into
nodejs:masterfrom
gengjiawen:feature/clang-format

Conversation

@gengjiawen

@gengjiawen gengjiawen commented Sep 4, 2019

Copy link
Copy Markdown
Member

Fix #111

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gengjiawen gengjiawen merged commit 1989e6e into nodejs:master Sep 6, 2019
@gengjiawen gengjiawen deleted the feature/clang-format branch September 6, 2019 12:11
SurienDG added a commit to SurienDG/node-addon-examples that referenced this pull request Sep 22, 2019
@kraenhansen

Copy link
Copy Markdown
Member

I suggest moving the dependency on clang-format to dev-dependencies: #616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add clang-format to this repo ?

4 participants