Merged
Conversation
anonrig
force-pushed
the
yagiz/add-rust-crate
branch
from
7a85dc3 to
dc36f2e
Compare
Member
|
I think we'll need to create a GitHub org team to be the owner team of the crate package, as documented at https://doc.rust-lang.org/cargo/reference/publishing.html#cargo-owner |
guybedford
approved these changes
Feb 25, 2026
Collaborator
guybedford
left a comment
guybedford
left a comment
There was a problem hiding this comment.
I wonder if there's an easy way to run the test harness against the Rust version to verify. Or at the very least get coverage on the various usage edge cases.
Hajime-san
reviewed
Feb 25, 2026
| toolchain: stable | ||
| - os: windows-latest | ||
| toolchain: stable | ||
|
|
There was a problem hiding this comment.
@dsherret @bartlomieju
Is it better to test on windows-11-arm?
Member
Author
Not that I know of, but we can always iterate! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Rust crate so Deno folks can use this rather than maintain their own library. Hopefully, this will bring the ecosystem one step closer to each other.
I released the first version: https://crates.io/crates/merve
cc @nodejs/tsc This will be the first project released to Crates.io. I'm not sure what's the best approach to share the ownership of this crate with TSC. For now, I've added a
CARGO_REGISTRY_TOKENsecret to the repository.