feat: Node.js 24.18.0#2546
Merged
Merged
Conversation
This comment was marked as spam.
This comment was marked as spam.
Member
|
Alpine/arm build should hopefully come out in an hour or so therefore it probably makes sense to wait for that. |
sxa
approved these changes
Jun 24, 2026
PeterDaveHello
approved these changes
Jun 24, 2026
|
Created PR on the official-images repo (docker-library/official-images#21722). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub. |
BYK
added a commit
to getsentry/craft
that referenced
this pull request
Jun 26, 2026
## What Upgrade craft's Docker base images and Volta toolchain from **Node 22.23.1** to **Node 24.18.0** (current LTS, "Krypton"), and bump `@types/node` to `^24`. ## Why Our recent hotfix (#837) pinned to **22.23.1** to escape the `ERR_STREAM_PREMATURE_CLOSE` regression that 22.23.0 introduced (the CVE-2026-48931 fix added a public `'data'` listener to idle `http.Agent` sockets, which made `node-fetch@2` report false premature-close errors on GCS auth calls). **24.18.0 carries the same fix** ([nodejs/node#64004](nodejs/node#64004), backported to both 22.x and 24.x), so it's free of the regression *and* moves us onto the latest LTS major. ##⚠️ Do not merge yet — blocked on Docker image The official `node:24.18.0-bookworm` images are **not published yet**. As of opening this PR: - `node:24.18.0-bookworm` / `-bookworm-slim` → **404** on Docker Hub - The only Node 24 image currently available is `24.17.0` — the *broken* release - docker-node PR [nodejs/docker-node#2546](nodejs/docker-node#2546) ("feat: Node.js 24.18.0") is open and will publish the images once merged + built The `image` CI check will fail until those base images are live. **Hold merge** until `node:24.18.0-bookworm` is pullable, then re-run the image build. ## Verification (local, on Node 24.18.0) - ✅ `pnpm typecheck` - ✅ `pnpm build` + binary runs (`craft --version`) - ✅ `pnpm test` — 1025 passed, 1 skipped (57 files) Lockfile diff is limited to `@types/node` 22.19.1 → 24.13.2; `lockfileVersion` unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action