build: remove unused i386 architecture

[MikeMcC399]

Description

Remove i386 from:

• architectures
• Dockerfile-debian.template
• Dockerfile-slim.template

Motivation and Context

The architecture i386 was last used with Node.js 10 and it was taken out of active usage with PR #1478 in 2021.

Cross-check with no usage of i386 in current versions.json

Testing Details

Smoke test with:

./update.sh -s
cd 24/trixie-slim
docker build -t trixie-slim-test .
cd ../..
git restore .

Example Output (if appropriate)

Confirmed successful from above test

Types of changes

• Documentation
• Version change (Update, remove or add more Node.js versions)
• Variant change (Update, remove or add more variants, or versions of variants)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Other (none of the above)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING.md document.
• All new and existing tests passed.

[nschonni]

Aside: I was thinking that it would be intersting if we could generate thses statements based on the values inside the version.json. Might not be simple with the current script though

[MikeMcC399]

I didn't try to optimize anything else in this PR apart from a clean-up of i386.
An enhancement could perhaps be a standalone linting script as a first step in automation.

[nschonni]

Noticed looking at something else, that there is still something in the Alpine template

docker-node/Dockerfile-alpine.template

Line 14 in 7fded69

x86) OPENSSL_ARCH=linux-elf;; \

Probably need to regenerate all the images, but maybe after the rust stuff is figured out

[MikeMcC399]

I didn't make a general cleanup / reconciliation effort here. I just noticed i386 in the architectures file left over there, and only addressed this one for now.

[nschonni]

Realizing now that this was missing the sync with the Debian templates, so we have a "dirty" repo when running update.sh

[MikeMcC399]

I didn't think that was necessary, since I didn't want to generate any new image immediately.

If you want me to follow up with a second PR to prime the generated Dockerfiles I'm happy to do that.

It's something that should probably be described in the CONTRIBUTING doc. For CircleCI changes to templates they explicitly request that you don't update the generated files, so it's really a matter of convention / agreement. See https://github.com/CircleCI-Public/cimg-node/blob/main/.github/CONTRIBUTING.md#contributions-and-pull-requests

Please let me know if I should take some action here, and apologies for not asking before I submitted the PR. It would have been better it I hadn't made assumptions!

[nschonni]

No you're fine, it is definitely a "it depends". It also has been an issue when the release keys get updated, since it makes the Bot produce PRs with unaffected versions.