Add rustc toolchain to alpine images#2488
Open
nikeee wants to merge 1 commit intonodejs:mainfrom
Open
Conversation
59e030f to
f4f3919
Compare
Ran `./update.sh 26 alpine3.22,alpine3.23`
Author
|
I'm currently unable to verify end-to-end that this fixes the issue as I'm getting a segfault after ~10 minutes when I try to build anything in this repository from source. But the warnings that it cannot find rustc/cargo are gone, so it will probably work. Might just run this through CI and see what happens.I don't think that it is related to the rust issue as it also happens on the main branch. Probably just my local broken docker instance. Update: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds rustc and cargo. Uses host-native architecture, so should fix the below-mentioned issues for every arch except x64.
Node requires at least rust 1.82, which is available in alpine 3.22/3.23 (they currently ship 1.87).
Motivation and Context
See #2486 and #2487
Testing Details
Still building.
Types of changes