Skip to content

web: don't render the search bar when orama-db isn't enabled #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devthedevil wants to merge 2 commits into
base: main
Choose a base branch
from
Open

web: don't render the search bar when orama-db isn't enabled #893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34b642a
web: only render search box when orama-db is enabled
devthedevil Jul 11, 2026
45bb9a4
web: only render search box when orama-db is enabled
devthedevil Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/generators/web/ui/components/NavBar.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,22 @@ import GitHubIcon from '@node-core/ui-components/Icons/Social/GitHub';
import SearchBox from './SearchBox';
import { useTheme } from '../hooks/useTheme.mjs';

import { repository } from '#theme/config';
import { hasSearch, repository } from '#theme/config';
import Logo from '#theme/Logo';

/**
* NavBar component that displays the headings, search, etc.
*/
export default ({ metadata }) => {
const [themePreference, setThemePreference] = useTheme();
const [themePreference, setThemePreference] = useState();

@cursor cursor Bot Jul 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theme hook replaced incorrectly

High Severity

useTheme() was swapped for bare useState() while the useTheme import remains. useState is not imported from React, so the navbar can throw at runtime. Even with an import, theme would not load from localStorage, would not apply data-theme on the document, and ThemeToggle would get an undefined currentTheme.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 45bb9a4. Configure here.


return (
<NavBar
Logo={Logo}
sidebarItemTogglerAriaLabel="Toggle navigation menu"
navItems={[]}
>
<SearchBox pathname={metadata.path} />
{hasSearch && <SearchBox pathname={metadata.path} />}
<ThemeToggle
onChange={setThemePreference}
currentTheme={themePreference}
Expand Down
4 changes: 4 additions & 0 deletions src/generators/web/utils/config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ export default function createConfigSource(input) {
versions: buildVersionEntries(config.changelog, pageURL),
editURL,
pages: buildPageList(input),
// Only the `web` generator's own bundle should ever render the search
// bar; if `orama-db` wasn't also requested, there's no search index for
// it to query, so the search box would render but silently do nothing.
hasSearch: (getConfig().target ?? []).includes('orama-db'),
};

const lines = Object.entries(exports).map(
Expand Down