Skip to content

增加一个函数签名和一个泛型参数 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hzgotb wants to merge 3 commits into from
Closed

增加一个函数签名和一个泛型参数 #26

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54a655d
feat: 增加_close签名便于派生类override
hzgotb Nov 10, 2025
e1477df
refactor: 将Base类改为泛型以支持自定义选项类型
hzgotb Nov 10, 2025
45ac3f9
refactor: 将_close方法改为可选并直接调用
hzgotb Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,13 @@ export interface BaseOptions<T = any> {
[key: string]: any;
}

export abstract class Base<T = any> extends ReadyEventEmitter {
options: BaseOptions<T>;
export abstract class Base<T = any, O extends BaseOptions<T> = BaseOptions<T>> extends ReadyEventEmitter {
options: O;
#closed = false;
#localStorage: AsyncLocalStorage<T>;

constructor(options?: BaseOptions<T>) {
/* @ts-expect-error just a placeholder, will be implemented in subclass */
protected _close(): Promise<void>;
Comment thread
hzgotb marked this conversation as resolved.
Outdated
constructor(options?: O) {
super();

if (options?.initMethod) {
Expand All @@ -43,7 +44,7 @@ export abstract class Base<T = any> extends ReadyEventEmitter {
});
});
}
this.options = options ?? {};
this.options = options ?? ({} as O);
this.#localStorage = this.options.localStorage ?? getAsyncLocalStorage<T>();
super.on('error', err => {
this._defaultErrorHandler(err);
Expand Down