Implement EBICS 3.0#102
Conversation
8f2e0c2 to
bbf8928
Compare
bbf8928 to
20bf8d1
Compare
|
Alright, EBICS 3.0 is working and ready to be reviewed. @nanov Note: The EBICS test enviornment of CreditSuisse seems to be dead. The one of ZKB has some flaws where pain.001 uploads submitted via EBICS 3.0 are accepted (both error codes 000000) but neither listed on their UI nor returned via camt.052/053. I talked to ZKB and they seemed to know / not to care too much since it's only a test platform. They suggested I just test in PROD :-). The test platform of PostFinance is working fine though. Maybe someone with access to a French platform could also verify that it works on those? |
Thanks for the update! 🙌 |
@sumbricht Not yet, we are in contact with Raiffeisen because we have a problem with their EBICS 3.0 BTU. I will keep you informed. |
|
Thank you for the work. I just initialized a user with your new code. Our bank at first however declined the keys as they did not compare key fingerprints but fingerprints of the certificates. |
|
|
||
| for (let i = 0; i < keyNodes.length; i++) { | ||
| const type = xpath.select('.//*[local-name(.)=\'AuthenticationVersion\' or local-name(.)=\'EncryptionVersion\']', keyNodes[i].parentNode)[0].textContent; | ||
| const certificateBase64 = select('//ds:X509Certificate', keyNodes[i])[0].textContent.trim(); |
There was a problem hiding this comment.
should be
const certificateBase64 = select('.//ds:X509Certificate', keyNodes[i])[0].textContent.trim();
Otherwise this will always return the first certificate
There was a problem hiding this comment.
Yes, I also stumbled across this... The code in my fork's "h3k" branch is a bit more up to date (https://github.com/sumbricht/node-ebics-client/tree/h3k), but no longer really maintained as my needs have changed recently and - unfortunately - the maintainer of this repo @nanov has not responded to my PR or any of my requests to become a co-maintainer.
Therefore I have decided to stop trying to contribute to this library :-/...
So this leaves my h3k branch in an unmaintained state, and there have been many developments going into it other than the H3K transaction. For most part it is working well, therefore feel free to use / fork it and make the best use of it. 🙂
Implementation of H005 schema for EBICS 3.0. Fixes #9, fixes #98, fixes #100, fixes #30, fixes #25
Here's a summary of the changes that should help what changed and why:
I'm happy for any suggestions