Added a lyrics fetching and display plugin by Pever3ll · Pull Request #554 · noctalia-dev/noctalia-plugins

Pever3ll · 2026-04-03T02:58:26Z

The plugin fetches lyrics using MPRIS data from lrclib.net and displays it in the bar.

github-actions · 2026-04-03T02:58:38Z

Automatic Manifest Check

File: lyrics-fetch/manifest.json

(H) Missing required property repository. For example:

"repository": "https://github.com/noctalia-dev/noctalia-plugins"

github-actions · 2026-04-03T02:58:54Z

Automatic Code Quality Review

File: lyrics-fetch/BarWidget.qml

(H) Line 273: Do not use hardcoded values, always prefer to use the Style singleton instead

+                spacing: 50

(H) Missing required property screen. For example:

property ShellScreen screen

(H) Missing required property widgetId. For example:

property string widgetId: ""

(H) Missing required property section. For example:

property string section: ""

(H) Missing required property sectionWidgetIndex. For example:

property int sectionWidgetIndex: -1

(H) Missing required property sectionWidgetsCount. For example:

property int sectionWidgetsCount: 0

File: lyrics-fetch/Settings.qml

(H) Line 38: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")

+        label: "Font Family"

(H) Line 39: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")

+        description: "Select the font for lyrics."

(H) Line 53: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")

+        label: "Font Size"

(H) Line 54: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")

+        description: "Text size in points."

(H) Line 76: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")

+        label: "Widget Width"

(H) Line 93: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")

+        label: "Scroll Speed"

(H) Line 110: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")

+        label: "Scroll Mode"

(H) Line 131: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")

+        label: "Adapt scroll speed to line"

(H) Line 139: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")

+        label: "Hide when empty"

(H) Line 147: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")

+        label: "Show display when paused"

github-actions · 2026-04-03T21:18:00Z

Automatic Manifest Check

File: lyrics-fetch/manifest.json

(H) Line 31: The repository field needs to point to the "https://github.com/noctalia-dev/noctalia-plugins" github repository!

+  "repository": "https://github.com/pever3ll/noctalia-plugins"

github-actions · 2026-04-03T21:18:11Z

Automatic Code Quality Review

File: lyrics-fetch/BarWidget.qml

(L) Line 140: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                    "label": pluginApi?.tr("settings.title") || "Settings",

File: lyrics-fetch/Main.qml

(L) Line 35: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                return pluginApi?.tr("lyrics.paused") || "Music paused"

(L) Line 40: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+            return pluginApi?.tr("lyrics.loading") || "Wait Loading 🪿"

File: lyrics-fetch/Settings.qml

(L) Line 38: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.font.title") || "Font Family"

(L) Line 39: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        description: pluginApi?.tr("settings.font.desc") || "Select the font for lyrics."

(L) Line 45: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        placeholder: pluginApi?.tr("settings.font.placeholder") || "Select a font..."

(L) Line 46: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        searchPlaceholder: pluginApi?.tr("settings.font.search-placeholder") || "Search fonts..."

(L) Line 53: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.font.size") || "Font Size"

(L) Line 54: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        description: pluginApi?.tr("settings.font.size-desc") || "Text size in points."

(L) Line 76: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.width") || "Widget Width"

(L) Line 93: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.scroll.speed") || "Scroll Speed"

(L) Line 110: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.scroll.mode.title") || "Scroll Mode"

(L) Line 114: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                name: pluginApi?.tr("settings.scroll.mode.always") || "Always Scroll",

(L) Line 118: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                name: pluginApi?.tr("settings.scroll.mode.hover") || "Scroll on Hover",

(L) Line 122: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                name: pluginApi?.tr("settings.scroll.mode.never") || "Don't Scroll",

(L) Line 131: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.scroll.adapt") || "Adapt scroll speed to line"

(L) Line 132: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        description: pluginApi?.tr("settings.scroll.adapt-desc") || "Change scroll speed based on length of line"

(L) Line 140: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.hide-when-empty") || "Hide when empty"

(L) Line 148: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("show-when-paused") || "Show display when paused"

github-actions · 2026-04-03T21:34:53Z

Automatic Manifest Check

File: lyrics-fetch/manifest.json

(H) Line 31: The repository field needs to point to the "https://github.com/noctalia-dev/noctalia-plugins" github repository!

+  "repository": "https://github.com/pever3ll/noctalia-plugins"

github-actions · 2026-04-03T21:35:10Z

Automatic Code Quality Review

File: lyrics-fetch/BarWidget.qml

(L) Line 140: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                    "label": pluginApi?.tr("settings.title") || "Settings",

File: lyrics-fetch/Main.qml

(L) Line 35: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                return pluginApi?.tr("lyrics.paused") || "Music paused"

(L) Line 40: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+            return pluginApi?.tr("lyrics.loading") || "Wait Loading 🪿"

File: lyrics-fetch/Settings.qml

(L) Line 38: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.font.title") || "Font Family"

(L) Line 39: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        description: pluginApi?.tr("settings.font.desc") || "Select the font for lyrics."

(L) Line 45: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        placeholder: pluginApi?.tr("settings.font.placeholder") || "Select a font..."

(L) Line 46: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        searchPlaceholder: pluginApi?.tr("settings.font.search-placeholder") || "Search fonts..."

(L) Line 53: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.font.size") || "Font Size"

(L) Line 54: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        description: pluginApi?.tr("settings.font.size-desc") || "Text size in points."

(L) Line 76: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.width") || "Widget Width"

(L) Line 93: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.scroll.speed") || "Scroll Speed"

(L) Line 110: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.scroll.mode.title") || "Scroll Mode"

(L) Line 114: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                name: pluginApi?.tr("settings.scroll.mode.always") || "Always Scroll",

(L) Line 118: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                name: pluginApi?.tr("settings.scroll.mode.hover") || "Scroll on Hover",

(L) Line 122: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                name: pluginApi?.tr("settings.scroll.mode.never") || "Don't Scroll",

(L) Line 131: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.scroll.adapt") || "Adapt scroll speed to line"

(L) Line 132: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        description: pluginApi?.tr("settings.scroll.adapt-desc") || "Change scroll speed based on length of line"

(L) Line 140: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.hide-when-empty") || "Hide when empty"

(L) Line 148: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("show-when-paused") || "Show display when paused"

github-actions · 2026-04-03T22:00:59Z

Automatic Manifest Check

File: lyrics-fetch/manifest.json

(H) Line 31: The repository field needs to point to the "https://github.com/noctalia-dev/noctalia-plugins" github repository!

+  "repository": "https://github.com/pever3ll/noctalia-plugins"

github-actions · 2026-04-03T22:01:13Z

Automatic Code Quality Review

File: lyrics-fetch/BarWidget.qml

(L) Line 140: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                    "label": pluginApi?.tr("settings.title") || "Settings",

File: lyrics-fetch/Main.qml

(L) Line 35: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                return pluginApi?.tr("lyrics.paused") || "Music paused"

(L) Line 40: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+            return pluginApi?.tr("lyrics.loading") || "Wait Loading 🪿"

File: lyrics-fetch/Settings.qml

(L) Line 38: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.font.title") || "Font Family"

(L) Line 39: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        description: pluginApi?.tr("settings.font.desc") || "Select the font for lyrics."

(L) Line 45: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        placeholder: pluginApi?.tr("settings.font.placeholder") || "Select a font..."

(L) Line 46: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        searchPlaceholder: pluginApi?.tr("settings.font.search-placeholder") || "Search fonts..."

(L) Line 53: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.font.size") || "Font Size"

(L) Line 54: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        description: pluginApi?.tr("settings.font.size-desc") || "Text size in points."

(L) Line 76: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.width") || "Widget Width"

(L) Line 93: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.scroll.speed") || "Scroll Speed"

(L) Line 110: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.scroll.mode.title") || "Scroll Mode"

(L) Line 114: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                name: pluginApi?.tr("settings.scroll.mode.always") || "Always Scroll",

(L) Line 118: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                name: pluginApi?.tr("settings.scroll.mode.hover") || "Scroll on Hover",

(L) Line 122: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                name: pluginApi?.tr("settings.scroll.mode.never") || "Don't Scroll",

(L) Line 131: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.scroll.adapt") || "Adapt scroll speed to line"

(L) Line 132: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        description: pluginApi?.tr("settings.scroll.adapt-desc") || "Change scroll speed based on length of line"

(L) Line 140: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.hide-when-empty") || "Hide when empty"

(L) Line 148: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("show-when-paused") || "Show display when paused"

github-actions · 2026-04-03T22:52:28Z

Automatic Manifest Check

File: lyrics-fetch/manifest.json

(H) Line 31: The repository field needs to point to the "https://github.com/noctalia-dev/noctalia-plugins" github repository!

+  "repository": "https://github.com/pever3ll/noctalia-plugins"

github-actions · 2026-04-03T22:52:42Z

Automatic Code Quality Review

File: lyrics-fetch/BarWidget.qml

(L) Line 140: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                    "label": pluginApi?.tr("settings.title") || "Settings",

File: lyrics-fetch/Main.qml

(L) Line 35: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                return pluginApi?.tr("lyrics.paused") || "Music paused"

(L) Line 40: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+            return pluginApi?.tr("lyrics.loading") || "Wait Loading 🪿"

File: lyrics-fetch/Settings.qml

(L) Line 38: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.font.title") || "Font Family"

(L) Line 39: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        description: pluginApi?.tr("settings.font.desc") || "Select the font for lyrics."

(L) Line 45: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        placeholder: pluginApi?.tr("settings.font.placeholder") || "Select a font..."

(L) Line 46: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        searchPlaceholder: pluginApi?.tr("settings.font.search-placeholder") || "Search fonts..."

(L) Line 53: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.font.size") || "Font Size"

(L) Line 54: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        description: pluginApi?.tr("settings.font.size-desc") || "Text size in points."

(L) Line 76: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.width") || "Widget Width"

(L) Line 93: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.scroll.speed") || "Scroll Speed"

(L) Line 110: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.scroll.mode.title") || "Scroll Mode"

(L) Line 114: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                name: pluginApi?.tr("settings.scroll.mode.always") || "Always Scroll",

(L) Line 118: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                name: pluginApi?.tr("settings.scroll.mode.hover") || "Scroll on Hover",

(L) Line 122: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                name: pluginApi?.tr("settings.scroll.mode.never") || "Don't Scroll",

(L) Line 131: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.scroll.adapt") || "Adapt scroll speed to line"

(L) Line 132: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        description: pluginApi?.tr("settings.scroll.adapt-desc") || "Change scroll speed based on length of line"

(L) Line 140: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.hide-when-empty") || "Hide when empty"

(L) Line 148: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("show-when-paused") || "Show display when paused"

github-actions · 2026-04-03T22:54:22Z

Automatic Manifest Check

File: lyrics-fetch/manifest.json

(H) Line 31: The repository field needs to point to the "https://github.com/noctalia-dev/noctalia-plugins" github repository!

+  "repository": "https://github.com/pever3ll/noctalia-plugins"

github-actions · 2026-04-03T22:54:33Z

Automatic Code Quality Review

File: lyrics-fetch/BarWidget.qml

(L) Line 140: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                    "label": pluginApi?.tr("settings.title") || "Settings",

File: lyrics-fetch/Main.qml

(L) Line 35: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                return pluginApi?.tr("lyrics.paused") || "Music paused"

(L) Line 40: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+            return pluginApi?.tr("lyrics.loading") || "Wait Loading 🪿"

File: lyrics-fetch/Settings.qml

(L) Line 38: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.font.title") || "Font Family"

(L) Line 39: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        description: pluginApi?.tr("settings.font.desc") || "Select the font for lyrics."

(L) Line 45: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        placeholder: pluginApi?.tr("settings.font.placeholder") || "Select a font..."

(L) Line 46: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        searchPlaceholder: pluginApi?.tr("settings.font.search-placeholder") || "Search fonts..."

(L) Line 53: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.font.size") || "Font Size"

(L) Line 54: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        description: pluginApi?.tr("settings.font.size-desc") || "Text size in points."

(L) Line 76: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.width") || "Widget Width"

(L) Line 93: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.scroll.speed") || "Scroll Speed"

(L) Line 110: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.scroll.mode.title") || "Scroll Mode"

(L) Line 114: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                name: pluginApi?.tr("settings.scroll.mode.always") || "Always Scroll",

(L) Line 118: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                name: pluginApi?.tr("settings.scroll.mode.hover") || "Scroll on Hover",

(L) Line 122: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                name: pluginApi?.tr("settings.scroll.mode.never") || "Don't Scroll",

(L) Line 131: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.scroll.adapt") || "Adapt scroll speed to line"

(L) Line 132: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        description: pluginApi?.tr("settings.scroll.adapt-desc") || "Change scroll speed based on length of line"

(L) Line 140: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.hide-when-empty") || "Hide when empty"

(L) Line 148: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("show-when-paused") || "Show display when paused"

github-actions · 2026-04-03T22:57:04Z

Automatic Code Quality Review

File: lyrics-fetch/BarWidget.qml

(L) Line 140: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                    "label": pluginApi?.tr("settings.title") || "Settings",

File: lyrics-fetch/Main.qml

(L) Line 35: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                return pluginApi?.tr("lyrics.paused") || "Music paused"

(L) Line 40: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+            return pluginApi?.tr("lyrics.loading") || "Wait Loading 🪿"

File: lyrics-fetch/Settings.qml

(L) Line 38: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.font.title") || "Font Family"

(L) Line 39: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        description: pluginApi?.tr("settings.font.desc") || "Select the font for lyrics."

(L) Line 45: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        placeholder: pluginApi?.tr("settings.font.placeholder") || "Select a font..."

(L) Line 46: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        searchPlaceholder: pluginApi?.tr("settings.font.search-placeholder") || "Search fonts..."

(L) Line 53: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.font.size") || "Font Size"

(L) Line 54: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        description: pluginApi?.tr("settings.font.size-desc") || "Text size in points."

(L) Line 76: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.width") || "Widget Width"

(L) Line 93: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.scroll.speed") || "Scroll Speed"

(L) Line 110: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.scroll.mode.title") || "Scroll Mode"

(L) Line 114: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                name: pluginApi?.tr("settings.scroll.mode.always") || "Always Scroll",

(L) Line 118: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                name: pluginApi?.tr("settings.scroll.mode.hover") || "Scroll on Hover",

(L) Line 122: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+                name: pluginApi?.tr("settings.scroll.mode.never") || "Don't Scroll",

(L) Line 131: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.scroll.adapt") || "Adapt scroll speed to line"

(L) Line 132: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        description: pluginApi?.tr("settings.scroll.adapt-desc") || "Change scroll speed based on length of line"

(L) Line 140: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("settings.hide-when-empty") || "Hide when empty"

(L) Line 148: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+        label: pluginApi?.tr("show-when-paused") || "Show display when paused"

spiros132 · 2026-04-09T12:49:53Z

Is this PR ready for review? :)

Pever3ll · 2026-04-09T15:26:04Z

Is this PR ready for review? :)

yes!

spiros132

Some minor feedback about the PR, otherwise ready to be merged :)

spiros132 · 2026-04-09T17:29:37Z

+                // Logger.d("songSeekProc", "playing:", data === "Playing")
+                // Logger.d("songSeekProc", "wasPlaying:", songSeekProc.lastState === "Playing")
+                if (data === "Playing" && songSeekProc.lastState === "Playing") {
+                    Logger.d("songSeekProc", "seeked")


I would suggest using the plugin name here. For example instead of using the songSeekProc, use LyricsFetch

spiros132 · 2026-04-09T17:30:58Z

+                try {
+                    lyrics = JSON.parse(output)?.syncedLyrics?.toString() || ""
+                } catch (e) {
+                    Logger.e("fetchLyricProc", "Error parsing JSON:", e)


Here as well, prefer for the first argument to be the plugin name, and maybe then describe where you are in the code. For example: `Logger.e("LyricsFetch", "Fetching Lyrics Process | Error parsing JSON:", e)

spiros132 · 2026-04-09T17:31:12Z

+                    Logger.e("fetchLyricProc", "Error parsing JSON:", e)
+                }
+                if (!lyrics) {
+                    Logger.e("fetchLyricProc", "No synced lyrics")


Here as well, use your plugins name.

Pever3ll · 2026-04-09T17:47:19Z

Done!

spiros132

Looks great! Thank you so much for the PR! :D

@ItsLemmy

Pever3ll added 2 commits April 2, 2026 19:50

lyrics-fetch plugin

4e6beb3

credit

a6e4b6d

Pever3ll marked this pull request as draft April 3, 2026 03:02

Pever3ll marked this pull request as ready for review April 3, 2026 03:03

Pever3ll marked this pull request as draft April 3, 2026 03:09

styling changes and click on widget

a7a87ae

fixed full comma from soundcloud metadata

293bd61

fixed spacing

9ba80a6

fixed soundcloud bug with position

4db7474

Pever3ll marked this pull request as ready for review April 3, 2026 22:53

Pever3ll closed this Apr 3, 2026

Pever3ll reopened this Apr 3, 2026

added noctalia repo as source

5cf60a6

Pever3ll added 3 commits April 3, 2026 16:43

final styling changes

df2e576

fix with playerctl on kde connect

96485dc

fix with playerctl focusing on wrong player

bf80d79

removed debug loggers and fixed lyric trimming

fe050a7

more loggers that i didnt catch

73f7e98

spiros132 reviewed Apr 9, 2026

View reviewed changes

Logger changed to have plugin name

3a8f71e

spiros132 reviewed Apr 9, 2026

View reviewed changes

spiros132 merged commit 5042466 into noctalia-dev:main Apr 13, 2026
2 checks passed

Conversation

Pever3ll commented Apr 3, 2026

Uh oh!

github-actions bot commented Apr 3, 2026

Automatic Manifest Check

File: lyrics-fetch/manifest.json

Uh oh!

github-actions bot commented Apr 3, 2026

Automatic Code Quality Review

File: lyrics-fetch/BarWidget.qml

File: lyrics-fetch/Settings.qml

Uh oh!

github-actions bot commented Apr 3, 2026

Automatic Manifest Check

File: lyrics-fetch/manifest.json

Uh oh!

github-actions bot commented Apr 3, 2026

Automatic Code Quality Review

File: lyrics-fetch/BarWidget.qml

File: lyrics-fetch/Main.qml

File: lyrics-fetch/Settings.qml

Uh oh!

github-actions bot commented Apr 3, 2026

Automatic Manifest Check

File: lyrics-fetch/manifest.json

Uh oh!

github-actions bot commented Apr 3, 2026

Automatic Code Quality Review

File: lyrics-fetch/BarWidget.qml

File: lyrics-fetch/Main.qml

File: lyrics-fetch/Settings.qml

Uh oh!

github-actions bot commented Apr 3, 2026

Automatic Manifest Check

File: lyrics-fetch/manifest.json

Uh oh!

github-actions bot commented Apr 3, 2026

Automatic Code Quality Review

File: lyrics-fetch/BarWidget.qml

File: lyrics-fetch/Main.qml

File: lyrics-fetch/Settings.qml

Uh oh!

github-actions bot commented Apr 3, 2026

Automatic Manifest Check

File: lyrics-fetch/manifest.json

Uh oh!

github-actions bot commented Apr 3, 2026

Automatic Code Quality Review

File: lyrics-fetch/BarWidget.qml

File: lyrics-fetch/Main.qml

File: lyrics-fetch/Settings.qml

Uh oh!

github-actions bot commented Apr 3, 2026

Automatic Manifest Check

File: lyrics-fetch/manifest.json

Uh oh!

github-actions bot commented Apr 3, 2026

Automatic Code Quality Review

File: lyrics-fetch/BarWidget.qml

File: lyrics-fetch/Main.qml

File: lyrics-fetch/Settings.qml

Uh oh!

github-actions bot commented Apr 3, 2026

Automatic Code Quality Review

File: lyrics-fetch/BarWidget.qml

File: lyrics-fetch/Main.qml

File: lyrics-fetch/Settings.qml

Uh oh!

spiros132 commented Apr 9, 2026

Uh oh!

Pever3ll commented Apr 9, 2026

Uh oh!

spiros132 left a comment

Choose a reason for hiding this comment

Uh oh!

spiros132 Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

spiros132 Apr 9, 2026

Choose a reason for hiding this comment