Add Linux WallpaperEngine Controller plugin by PaloMiku · Pull Request #552 · noctalia-dev/noctalia-plugins

PaloMiku · 2026-04-02T19:15:42Z

Introduced a new plugin for Noctalia to control linux-wallpaperengine with features for per-screen wallpaper selection.
Added README.md for documentation on usage, requirements, and troubleshooting.
Implemented Settings.qml for user configuration of wallpaper settings including folder paths, scaling options, and audio settings.
Created i18n files for English, Japanese, Simplified Chinese, and Traditional Chinese to support multiple languages.
Added manifest.json to define plugin metadata and entry points.
Included a preview image for the plugin.

Preview Panel:

- Introduced a new plugin for Noctalia to control linux-wallpaperengine with features for per-screen wallpaper selection. - Added README.md for documentation on usage, requirements, and troubleshooting. - Implemented Settings.qml for user configuration of wallpaper settings including folder paths, scaling options, and audio settings. - Created i18n files for English, Japanese, Simplified Chinese, and Traditional Chinese to support multiple languages. - Added manifest.json to define plugin metadata and entry points. - Included a preview image for the plugin.

github-actions · 2026-04-02T19:16:35Z

Automatic Code Quality Review

File: linux-wallpaperengine-controller/Panel.qml

(H) Line 444: Do not use hardcoded values, always prefer to use the Style singleton instead

+          border.width: 1

(H) Line 462: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")

+                text: "Linux-WallpaperEngine"

(H) Line 569: Do not use hardcoded values, always prefer to use the Style singleton instead

+                border.width: 1

(H) Line 617: Do not use hardcoded values, always prefer to use the Style singleton instead

+                border.width: 1

(H) Line 666: Do not use hardcoded values, always prefer to use the Style singleton instead

+          border.width: 1

(H) Line 842: Do not use hardcoded values, always prefer to use the Style singleton instead

+                border.width: 1

(H) Line 1118: Do not use hardcoded values, always prefer to use the Style singleton instead

+    border.width: 1

(H) Line 1171: Do not use hardcoded values, always prefer to use the Style singleton instead

+    border.width: 1

Copilot

Pull request overview

This PR introduces a new Linux WallpaperEngine Controller plugin for Noctalia, providing a bar widget + panel UI to browse Steam Workshop wallpaper projects and control the linux-wallpaperengine runtime.

Changes:

Added a new plugin implementation (engine control, IPC commands, bar widget, and a panel UI with scanning/search/sort/filter).
Added plugin settings UI and default configuration via manifest.json.
Added documentation and i18n resources (EN/JA/zh-CN/zh-TW), plus a preview image.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
linux-wallpaperengine-controller/manifest.json	Declares plugin metadata, entry points, and default settings.
linux-wallpaperengine-controller/Main.qml	Implements engine availability checks, command building, process control, and IPC handlers.
linux-wallpaperengine-controller/Panel.qml	Adds the browsing/apply UI, folder scanning process, and per-screen/all-displays controls.
linux-wallpaperengine-controller/Settings.qml	Adds a settings page for defaults (FPS, scaling, audio flags, folder config).
linux-wallpaperengine-controller/BarWidget.qml	Adds a bar icon with tooltip state and context menu actions (reload/stop/settings).
linux-wallpaperengine-controller/README.md	Documents requirements, usage, IPC commands, and troubleshooting.
linux-wallpaperengine-controller/i18n/en.json	English translations for widget/menu/panel/settings strings.
linux-wallpaperengine-controller/i18n/ja.json	Japanese translations.
linux-wallpaperengine-controller/i18n/zh-CN.json	Simplified Chinese translations.
linux-wallpaperengine-controller/i18n/zh-TW.json	Traditional Chinese translations.
linux-wallpaperengine-controller/preview.png	Plugin preview image.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-02T19:21:49Z

+  property string editWallpapersFolder: cfg.wallpapersFolder ?? defaults.wallpapersFolder ?? ""
+  property string editDefaultScaling: cfg.defaultScaling ?? defaults.defaultScaling ?? "fill"
+  property int editDefaultFps: cfg.defaultFps ?? defaults.defaultFps ?? 30
+  property int editDefaultVolume: cfg.defaultVolume ?? defaults.defaultVolume ?? 100
+  property bool editDefaultMuted: cfg.defaultMuted ?? defaults.defaultMuted ?? true
+  property bool editDefaultAudioReactiveEffects: cfg.defaultAudioReactiveEffects ?? defaults.defaultAudioReactiveEffects ?? true


manifest.json defines assetsDir and autoApplyOnStartup defaults (and Main.qml reads both), but Settings.qml doesn't expose controls for them or persist them in saveSettings(). Add UI inputs/toggles for these settings and write them into pluginApi.pluginSettings so users can configure assets directory and startup behavior from the settings screen.

Copilot · 2026-04-02T19:21:51Z

+## Basic Troubleshooting
+
+- Check binary in PATH: `command -v linux-wallpaperengine`
+- If panel shows folder error: verify `Wallpapers source folder` exists and contains wallpaper project folders
+- If engine fails to start: recheck dependencies and GPU/OpenGL environment
+- For runtime logs: start shell with debug: `NOCTALIA_DEBUG=1 qs -c noctalia-shell`


The troubleshooting/docs mention folder configuration and PATH checks, but Main.qml can emit an assets-related error (main.error.assetsMissing) that instructs users to configure an assets directory—yet the README doesn't explain where to set this or what path is expected. Update the README to document the assets directory requirement and how to configure it (once the settings UI supports it).

…ng logic

…ne controller

github-actions · 2026-04-02T20:05:17Z

Automatic Code Quality Review

File: linux-wallpaperengine-controller/Main.qml

(L) Line 443: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+    const hint = String(pluginApi?.tr("main.error.autoRecovered") || "").trim();

…ction

spiros132

Some feedback about the PR :)

PaloMiku · 2026-04-04T02:12:33Z

Some feedback about the PR :)关于公关:)的一些反馈

Thank you for your guidance! I will make the revisions as soon as possible :)

…improve readability

spiros132 · 2026-04-05T19:04:23Z

When you feel like you're ready with the changes, ping me :)

…logic

spiros132

Some more feedback about the PR :)

spiros132 · 2026-04-06T14:29:32Z

+    running: false
+    command: [
+      "sh", "-c",
+      "for common in \"$HOME/.steam/steam/steamapps/common\" \"$HOME/.local/share/Steam/steamapps/common\" \"$HOME/.var/app/com.valvesoftware.Steam/.local/share/Steam/steamapps/common\" \"$HOME/snap/steam/common/.local/share/Steam/steamapps/common\"; do if [ -d \"$common\" ]; then workshop=\"${common%/common}/workshop/content/431960\"; if [ -d \"$workshop\" ]; then printf '%s\\n' \"$workshop\"; exit 0; fi; fi; done; exit 0"


Would it be possible to move these scripts to their own files to make it easier to read them and for better organization? For example if there's either a "scripts" folder or a "assets/scripts" folder.

Sounds good!

spiros132 · 2026-04-06T14:31:10Z

+      from: 1
+      to: 240
+      value: root.editDefaultFps
+      suffix: " FPS"


I'm curious, would this fit as a translation or is it the same on every language?

FPS is written the same way as an abbreviation in most languages, namely FPS / fps; only its full name varies across different languages.

…unctionality

…lity

…ed readability

spiros132

Some minor feedback otherwise I think it's ready to be merged. :)

spiros132 · 2026-04-07T10:50:40Z

      delegate: Rectangle {
        required property var modelData
-        width: ListView.view.width
+        width: NListView.view.width


I'm not sure this property exists. Did you maybe mean filterList.width?

I may have misread the documentation somewhere :(
Fixed

spiros132 · 2026-04-07T11:14:37Z

Looks great! Thank you so much for the PR! :D

@ItsLemmy

Copilot AI review requested due to automatic review settings April 2, 2026 19:15

Copilot started reviewing on behalf of PaloMiku April 2, 2026 19:16 View session

fix: standardize panel title across languages and update border styles

8e4dae0

Copilot AI reviewed Apr 2, 2026

View reviewed changes

PaloMiku added 3 commits April 3, 2026 03:30

feat: add assets directory configuration and improve wallpaper scanni…

6648a98

…ng logic

fix: remove unnecessary preview active condition from tile card logic

73c3f05

feat: implement runtime recovery and error handling in wallpaper engi…

1097a1c

…ne controller

PaloMiku added 3 commits April 3, 2026 04:19

fix: improve error recovery hint handling in markErrorAsRecovered fun…

f53067e

…ction

fix: update error messages and improve UI text for clarity

25b8c22

fix: update error banner colors for improved visibility and consistency

a2d0338

spiros132 reviewed Apr 3, 2026

View reviewed changes

PaloMiku added 2 commits April 4, 2026 10:32

refactor: update function signatures to include type annotations and …

4fbd84d

…improve readability

fix: ensure engine availability checks handle null values gracefully

5edb24b

PaloMiku added 4 commits April 6, 2026 11:33

fix: enhance single screen mode handling and improve display options …

d719a76

…logic

fix: remove auto-detect workshop feature and related translations

099af68

fix: ensure proper termination of detached processes during engine stop

dfeb03a

fix: update preview image for wallpaper engine controller

efd98df

PaloMiku requested a review from spiros132 April 6, 2026 04:37

spiros132 reviewed Apr 6, 2026

View reviewed changes

PaloMiku added 2 commits April 7, 2026 09:41

fix: refactor wallpaper scanning and detection scripts for improved f…

6629abb

…unctionality

fix: format and align text elements in Panel.qml for improved readabi…

34530f8

…lity

PaloMiku requested a review from spiros132 April 7, 2026 01:49

PaloMiku added 3 commits April 7, 2026 10:01

fix: update translations for filter types and improve manifest version

06df03d

fix: format and align image and text elements in Panel.qml for improv…

4e96f32

…ed readability

feat: Update manifest tag

fc1b886

spiros132 reviewed Apr 7, 2026

View reviewed changes

fix: update width properties in Panel.qml for filter and sort lists

ccd160e

ItsLemmy merged commit 80b3c5b into noctalia-dev:main Apr 7, 2026
2 checks passed

Conversation

PaloMiku commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 2, 2026

Automatic Code Quality Review

File: linux-wallpaperengine-controller/Panel.qml

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Apr 2, 2026

Automatic Code Quality Review

File: linux-wallpaperengine-controller/Main.qml

Uh oh!

spiros132 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PaloMiku commented Apr 4, 2026

Uh oh!

spiros132 commented Apr 5, 2026

Uh oh!

spiros132 left a comment

Choose a reason for hiding this comment

Uh oh!

spiros132 Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

PaloMiku Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

spiros132 Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

PaloMiku Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

spiros132 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spiros132 Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

PaloMiku Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

spiros132 commented Apr 7, 2026

PaloMiku commented Apr 2, 2026 •

edited

Loading

spiros132 left a comment •

edited

Loading