feat(simple-notes): icon customization, hide widget, IPC toggle, and file export (v1.1.0) by fusuyfusuy · Pull Request #378 · noctalia-dev/noctalia-plugins

fusuyfusuy · 2026-03-16T17:34:02Z

Implemented this requests: #212

Summary

Add customizable bar icon via NIconPicker (pattern: update-count)
Add hide bar widget toggle with smooth opacity/size animation (pattern: screen-recorder)
Add IPC handler for togglePanel with keyboard shortcut display in Settings (pattern: notes-scratchpad)
Add optional .md file export with directory picker and per-note filenames (pattern: notes-scratchpad FileView)
Bump version 1.0.3 → 1.1.0, add missing default settings, add i18n keys

Changes from review feedback (@spiros132)

Use cfg/defaults pattern throughout: cfg.key ?? defaults.key ?? fallback so defaultSettings in manifest.json are actually used as fallbacks
Removed Component.onCompleted settings initialization from Main.qml — defaults are now handled by the cfg/defaults pattern in each component
Removed all translation fallback strings (|| 'Value') from Panel.qml and Settings.qml
Added error handling for file export: try/catch in exportNoteToFile(), exportError state property, and a dismissable error banner in the Panel UI
Changed notesDirectory default to ~/Documents in manifest.json

spiros132

Some feedback and questions about the PR :)

spiros132 · 2026-03-16T18:17:22Z

+    id: fileExporter
+    path: ""
+    watchChanges: false
+  }


Would it be possible to have some type of error handling so that the user would be able to know what was wrong if the file was weirdly formatted?

spiros132 · 2026-03-16T18:23:44Z

+      "positionMode": "attached",
+      "barIcon": "paperclip",
+      "hideBarWidget": false,
+      "notesDirectory": ""


I'm a bit confused you are including these defaultSettings but not including them anywhere in the code. For example you could do the following:

// Instead of this readonly property string barIcon: pluginApi?.pluginSettings?.barIcon ?? "paperclip" // You can have the following instead: // (NOTE: the following functions aren't needed but you can add them for readabilities sake) readonly property cfg: pluginApi?.pluginSettings ?? ({}) readonly property defaults: pluginApi?.manifest?.metadata?.defaultSettings ?? ({}) readonly property string barIcon: cfg.barIcon ?? defaults.barIcon ?? "paperclip"

spiros132 · 2026-03-16T18:24:16Z

  property real contentPreferredWidth: 700 * Style.uiScaleRatio
  property real contentPreferredHeight: 500 * Style.uiScaleRatio
-  readonly property bool allowAttach: true
+  readonly property string positionMode: pluginApi?.pluginSettings?.positionMode || "attached"


An example of the above comment is here

spiros132 · 2026-03-16T18:25:59Z

+      if (pluginApi.pluginSettings.notesDirectory === undefined) {
+        pluginApi.pluginSettings.notesDirectory = "";
+        pluginApi.saveSettings();
+      }


In my opinion you shouldn't depend on the main file to instantiate and save the settings. By using the method before with the default settings you could technically also have the following:

// As a quick example with no fallback value since the value is taken from the defaults ... readonly property key: cfg.key ?? defaults.key ?? ""

spiros132 · 2026-03-16T18:28:03Z

+              Layout.fillWidth: true
+              placeholderText: titleInput.text
+                ? root.sanitizeFileName(titleInput.text)
+                : (pluginApi?.tr("panel.editor.filename_placeholder") || "auto-generated-from-title.md")


When it comes to translations, you don't need to use fallback values anymore. So the following works:

// From: pluginApi?.tr("key") || "Value" // To this: pluginApi?.tr("key")

spiros132 · 2026-03-16T18:29:01Z

+      "positionMode": "attached",
+      "barIcon": "paperclip",
+      "hideBarWidget": false,
+      "notesDirectory": ""


Would the ~/Documents folder be a good default for the notesDirectory?

spiros132 · 2026-03-16T18:30:39Z

+  // 3. Hide Bar Widget
+  NToggle {
+    label: pluginApi?.tr("settings.hide_bar_widget.label") || "Hide Bar Widget"
+    description: pluginApi?.tr("settings.hide_bar_widget.description") || "Hide the bar widget from the status bar"


As before you don't need translation fallbacks anymore

fusuyfusuy · 2026-03-23T06:27:18Z

Thx for the feedback. Working on it

github-actions · 2026-04-07T17:42:09Z

Automatic Code Quality Review

File: simple-notes/BarWidget.qml

(H) Missing required property sectionWidgetIndex. For example:

property int sectionWidgetIndex: -1

(H) Missing required property sectionWidgetsCount. For example:

property int sectionWidgetsCount: 0

File: simple-notes/Panel.qml

(L) Line 98: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+      root.exportError = pluginApi?.tr("panel.export.error") ?? ("Failed to export note: " + e);

File: simple-notes/Settings.qml

(H) Line 146: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")

+        text: "qs -c noctalia-shell ipc call plugin:simple-notes togglePanel"

github-actions · 2026-04-07T18:03:08Z

Automatic Code Quality Review

File: simple-notes/Panel.qml

(L) Line 85: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+      root.exportError = pluginApi?.tr("panel.export.error") ?? ("Failed to export note: " + e);

File: simple-notes/Settings.qml

(H) Line 130: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")

+        text: "qs -c noctalia-shell ipc call plugin:simple-notes togglePanel"

github-actions · 2026-04-07T18:08:11Z

Automatic Code Quality Review

File: simple-notes/Panel.qml

(L) Line 85: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+      root.exportError = pluginApi?.tr("panel.export.error") ?? ("Failed to export note: " + e);

File: simple-notes/Settings.qml

(H) Line 130: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")

+        text: "qs -c noctalia-shell ipc call plugin:simple-notes togglePanel"

@spiros132

… export (v1.1.0) Implements: noctalia-dev#212 Changes: - Add customizable bar icon via NIconPicker (pattern: update-count) - Add hide bar widget toggle with smooth opacity/size animation - Add IPC handler for togglePanel with keyboard shortcut display in Settings - Add optional .md file export with directory picker and per-note filenames - Bump version 1.0.3 -> 1.1.0 Review feedback addressed (@spiros132): - Use cfg/defaults pattern throughout: cfg.key ?? defaults.key ?? fallback so defaultSettings in manifest.json are actually used as fallbacks - Remove Component.onCompleted settings initialization from Main.qml - Remove translation fallback strings (|| 'Value') from Panel.qml and Settings.qml - Add error handling for file export: try/catch, exportError state, dismissable error banner in the Panel UI - Change notesDirectory default to ~/Documents in manifest.json Upstream changes incorporated: - Add mandatory sectionWidgetIndex and sectionWidgetsCount props to BarWidget.qml - Fix NButton delete button to use backgroundColor instead of color (704eb32)

github-actions · 2026-04-07T18:10:09Z

Automatic Code Quality Review

File: simple-notes/Panel.qml

(L) Line 85: When it comes to translations there is no need for fallback values. From: pluginApi?.tr("example") || "value". To: pluginApi?.tr("example")

+      root.exportError = pluginApi?.tr("panel.export.error") ?? ("Failed to export note: " + e);

File: simple-notes/Settings.qml

(H) Line 130: Use translations instead of hardcoded text. Instead of: "Example Label". To: pluginApi?.tr("panel.example-label")

+        text: "qs -c noctalia-shell ipc call plugin:simple-notes togglePanel"

spiros132 reviewed Mar 16, 2026

View reviewed changes

ItsLemmy marked this pull request as draft March 19, 2026 22:29

fusuyfusuy mentioned this pull request Apr 6, 2026

Add IpcHandler for toggling plugin panel #539

Merged

fusuyfusuy force-pushed the main branch from 8ac1273 to 63a4681 Compare April 7, 2026 18:07

fusuyfusuy force-pushed the main branch from 63a4681 to a9e4e41 Compare April 7, 2026 18:09

Conversation

fusuyfusuy commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spiros132 left a comment

Choose a reason for hiding this comment

Uh oh!

spiros132 Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

spiros132 Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

spiros132 Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

spiros132 Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

spiros132 Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

spiros132 Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

spiros132 Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

fusuyfusuy commented Mar 23, 2026

Uh oh!

github-actions bot commented Apr 7, 2026

Automatic Code Quality Review

File: simple-notes/BarWidget.qml

File: simple-notes/Panel.qml

File: simple-notes/Settings.qml

Uh oh!

github-actions bot commented Apr 7, 2026

Automatic Code Quality Review

File: simple-notes/Panel.qml

File: simple-notes/Settings.qml

Uh oh!

github-actions bot commented Apr 7, 2026

Automatic Code Quality Review

File: simple-notes/Panel.qml

File: simple-notes/Settings.qml

Uh oh!

github-actions bot commented Apr 7, 2026

Automatic Code Quality Review

File: simple-notes/Panel.qml

File: simple-notes/Settings.qml

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fusuyfusuy commented Mar 16, 2026 •

edited

Loading