Skip to content

OpenID4VC initial merge#1038

Open
erbenjak wants to merge 220 commits into
mainfrom
openid4vc-v1-merge
Open

OpenID4VC initial merge#1038
erbenjak wants to merge 220 commits into
mainfrom
openid4vc-v1-merge

Conversation

@erbenjak
Copy link
Copy Markdown

@erbenjak erbenjak commented Apr 28, 2026

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

erbenjak and others added 30 commits August 20, 2025 14:20
@erbenjak
feat: add openid4vc controller
bdf3d39
@erbenjak
feat: add openid4vc facade
4e4ecc3
@erbenjak
feat: add ReolveCredentialOffer UseCase
1f73913
@erbenjak
feat: add dummy resolve credential offer datatype
1fad70a
@erbenjak
chore: rename facade
cffd31f
@erbenjak
chore: install credo library
3ecc6a4
@erbenjak
feat: add first simple test
ca57c0e
@erbenjak
feat: first working version
39a1ddb
@tnotheis
feat: add attribute value type VerifiableCredential
3e5dc7b
@erbenjak
WIP
67ad8a5
@mergify
Merge branch 'main' into poc-credo-holder-in-app-runtime
9742590
@erbenjak
feat: finish openid4vc controller
5e8aed4
@mergify
Merge branch 'main' into poc-credo-holder-in-app-runtime
508f799
@mergify
Merge branch 'release/v7' into poc-credo-holder-in-app-runtime
2cff733
@jkoenig134
Merge branch 'release/v7' into poc-credo-holder-in-app-runtime
8e4c3c9
@mergify
Merge branch 'release/v7' into poc-credo-holder-in-app-runtime
ade7f1b
@mergify
Merge branch 'release/v7' into poc-credo-holder-in-app-runtime
238e03d
@mergify
Merge branch 'release/v7' into poc-credo-holder-in-app-runtime
c97801c
@mergify
Merge branch 'release/v7' into poc-credo-holder-in-app-runtime
4a6f6e8
@erbenjak
chore: activate skip lib check
a2a3f43
@erbenjak
chore: correct dependencies
2e0c1b9
@erbenjak
feat: add mocks for some credo functionalities
0a04ae6
@erbenjak
feat: make test fetch offer url on its own
52e3c83
@erbenjak
feat: change holder to work without node spcific code
fef0649
@erbenjak
fix: facade return type
2bd7039
@erbenjak
fix: return value
d05dd1b
@erbenjak
Merge branch 'poc-credo-holder-in-app-runtime' of github.com:nmshd/ru…
9310761 
…ntime into poc-credo-holder-in-app-runtime
@jkoenig134
chore: update schemas
1b78e6c
@jkoenig134
Merge branch 'release/v7' into poc-credo-holder-in-app-runtime
90ec9ab
@erbenjak
fix: remove reference to global
afe4c14
Milena-Czierlinski
Milena-Czierlinski reviewed May 5, 2026
View reviewed changes
Comment thread packages/app-runtime/src/AppStringProcessor.ts
Comment thread packages/app-runtime/src/AppStringProcessor.ts
Comment thread packages/consumption/src/modules/openid4vc/local/EnmeshedHolderFileSystem.ts Outdated
Comment thread packages/consumption/src/modules/openid4vc/local/EnmeshedHolderKeyManagementService.ts Outdated
Comment thread packages/consumption/src/modules/openid4vc/local/EnmeshedStorageService.ts Outdated
Comment thread packages/runtime/test/consumption/openid4vc.test.ts Outdated
Comment thread packages/consumption/src/modules/openid4vc/OpenId4VcController.ts Outdated
britsta
britsta reviewed May 18, 2026
View reviewed changes
Comment thread .ci/runChecks.sh Outdated
britsta
britsta reviewed May 18, 2026
View reviewed changes
Comment thread packages/app-runtime/src/AppRuntimeErrors.ts Outdated
Comment thread packages/app-runtime/test/lib/MockUIBridge.matchers.ts Outdated
Comment thread packages/app-runtime/test/lib/MockUIBridge.matchers.ts Outdated
Comment thread packages/consumption/src/modules/openid4vc/local/EnmeshedHolderKeyManagementService.ts
Comment thread packages/consumption/src/modules/openid4vc/local/EnmeshedHolderKeyManagementService.ts
Comment thread packages/consumption/src/modules/openid4vc/OpenId4VcController.ts Outdated
Comment thread packages/runtime/test/consumption/openid4vc.test.ts
Milena-Czierlinski
Milena-Czierlinski reviewed May 19, 2026
View reviewed changes
Comment thread packages/app-runtime/src/AppStringProcessor.ts Outdated
Comment thread packages/consumption/src/modules/openid4vc/local/EnmeshedHolderKeyManagementService.ts Outdated
@Milena-Czierlinski
Copy link
Copy Markdown
Member

Milena-Czierlinski commented May 19, 2026

Regarding the vulnerabilities causing the failing pipeline: You can apply available fixes by running npm audit fix. If for a vulnerability there is no fix available yet, you can exclude it for the time being. Therefore, you run npx better-npm-audit audit to get the ids of the vulnerabilities. Then, you add them to the exclude flag in the runChecks.sh file.

Milena-Czierlinski
Milena-Czierlinski approved these changes May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Milena-Czierlinski Milena-Czierlinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Milena-Czierlinski Milena-Czierlinski changed the title Openid4vc initial merge OpenID4VC initial merge May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@britsta britsta britsta left review comments

Copilot code review Copilot Copilot left review comments

@Milena-Czierlinski Milena-Czierlinski Milena-Czierlinski approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@erbenjak @Milena-Czierlinski @britsta @tnotheis @jkoenig134 @Magnus-Kuhn @nicole-eb