[fix] convert_output() with updated SS3 report file#272
Open
Schiano-NOAA wants to merge 4 commits into
Open
Conversation
…sed on blank row OR relative to the next place report is mentioned
Contributor
New version checklist
|
Contributor
Code Metrics Report
Code coverage of files in pull request scope (50.0%)
Reported by octocov |
Collaborator
Author
|
@iantaylor-NOAA could test out convert_output() on this branch with the newest versions of SS3? I tested it out with an example Jason sent me and it works not, but doesn't hurt to test on other stocks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues users were encountering when convert_output() was failing with the most recent version of SS3.
This should be now fixed and still work as previously expected.