Skip to content

ACF-aware field writes + per-source post type for feeds#12

Merged
nmbrthirteen merged 1 commit into
mainfrom
feature/acf-and-per-source-posttype
Jun 30, 2026
Merged

ACF-aware field writes + per-source post type for feeds#12
nmbrthirteen merged 1 commit into
mainfrom
feature/acf-and-per-source-posttype

Conversation

@nmbrthirteen

Copy link
Copy Markdown
Owner

Answers two questions: how to delegate content into ACF fields properly, and how to send a feed to a different post type.

ACF-aware writes

Meta::write() uses ACF's update_field() when ACF is active, so mapped values and rule results land in the matching ACF field with its field-key reference — the ACF editor shows them and date/select fields format correctly. Falls back to update_post_meta when ACF isn't present. Wired into FieldMapper output, scrape rules, and both rule refreshers.

Per-source post type for any source

The per-source "Save items as (post type)" now applies to feeds too, not just scrapers — PostFactory::create() and taxonomy assignment honor the source's post type, and the field shows for every source. So you can route one RSS feed into event (or any CPT) and another into post.

86 tests green, lint clean.

- Meta::write uses ACF update_field() when ACF is active, so mapped/rule values
  land in the matching ACF field (with its field-key reference) instead of a bare
  meta row; falls back to update_post_meta otherwise. Used by FieldMapper output,
  scrape rules, and both rule refreshers.
- Per-source post type now applies to ALL sources (feeds too), not just scrapers:
  PostFactory::create() and assign_terms() honor the source's post type; the
  'Save items as (post type)' field shows for every source.
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@nmbrthirteen, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 27 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0d5ad8ce-a85f-4d55-b1d5-15b9d1e34012

📥 Commits

Reviewing files that changed from the base of the PR and between e189aa4 and f3c57e4.

📒 Files selected for processing (6)
  • src/Admin/Admin.php
  • src/Admin/views/sources.php
  • src/Maintenance/GlobalRulesRefresher.php
  • src/Maintenance/RulesRefresher.php
  • src/Publish/Meta.php
  • src/Publish/PostFactory.php
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/acf-and-per-source-posttype

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nmbrthirteen
nmbrthirteen merged commit 644d62c into main Jun 30, 2026
6 checks passed
@nmbrthirteen
nmbrthirteen deleted the feature/acf-and-per-source-posttype branch June 30, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant