Skip to content

fix: upgrade http:// to https:// in README.md#5280

Open
hanu-14 wants to merge 1 commit into
nlohmann:developfrom
hanu-14:fix-https-readme-md
Open

fix: upgrade http:// to https:// in README.md#5280
hanu-14 wants to merge 1 commit into
nlohmann:developfrom
hanu-14:fix-https-readme-md

Conversation

@hanu-14

@hanu-14 hanu-14 commented Jul 18, 2026

Copy link
Copy Markdown

Upgraded 2 http:// links to https://.

@nlohmann

Copy link
Copy Markdown
Owner

Please check the DCO requirements - see the link for the failed CI job.

@nlohmann nlohmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment: please fix the DCO
requirements

@hanu-14

hanu-14 commented Jul 19, 2026

Copy link
Copy Markdown
Author

Thanks for the review! I'll check the DCO requirements from the failed CI job link and make sure my commits are properly signed off (or amend/rebase accordingly) so the check passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants