Skip to content

ci: improve actions workflows#4388

Open
luc122c wants to merge 2 commits into
nitrojs:mainfrom
luc122c:actions-improvements
Open

ci: improve actions workflows#4388
luc122c wants to merge 2 commits into
nitrojs:mainfrom
luc122c:actions-improvements

Conversation

@luc122c

@luc122c luc122c commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

GitHub Actions announced the parallel keyword yesterday — syntactic sugar that groups independent steps to run concurrently within a single job, then waits for all of them before continuing. See the workflow syntax docs for the full reference.

Workflow Job Parallelised steps
ci.yml tests-checks pnpm typecheck + pnpm vitest run test/unit + pnpm vitest run test/minimal + pnpm vitest run test/vite
ci.yml tests-rollup pnpm vitest run test/examples + pnpm vitest run test/presets
ci.yml tests-rolldown pnpm vitest run test/examples + pnpm vitest run test/presets
npm-publish.yml publish pnpm lint + pnpm typecheck + pnpm test:rolldown

I've also scoped the nightly publish job to only run in this repo, not forks.

Related:

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@luc122c luc122c requested a review from pi0 as a code owner June 26, 2026 22:46
@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown

@luc122c is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 28687d12-1686-4bf8-835d-f16d6d67c46e

📥 Commits

Reviewing files that changed from the base of the PR and between 83acc44 and 58335f8.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • .github/workflows/npm-publish.yml

📝 Walkthrough

Walkthrough

CI workflows now run selected typecheck and vitest commands in parallel, the nightly publish job is limited to push events on main in nitrojs/nitro, and the npm publish workflow runs lint, typecheck, and rolldown tests in parallel.

Changes

Workflow updates

Layer / File(s) Summary
Parallel test jobs
.github/workflows/ci.yml
tests-checks, tests-rollup, and tests-rolldown move their typecheck and vitest commands into parallel blocks.
Nightly publish gate
.github/workflows/ci.yml
publish-nitro-nightly now requires a push to refs/heads/main in nitrojs/nitro.
npm publish parallel checks
.github/workflows/npm-publish.yml
pnpm lint, pnpm typecheck, and pnpm test:rolldown now run in a parallel group before publish.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • nitrojs/nitro#4278: Updates the same publish-nitro-nightly trigger condition in .github/workflows/ci.yml.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title follows conventional commits and accurately reflects the workflow optimization changes.
Description check ✅ Passed The description clearly matches the CI workflow changes and the nightly publish restriction.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Jun 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/nitro@4388

commit: 58335f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant