support ETaccessorBase as a type with its own symbol#205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ETaccessorBase class in C++ is the base class for the system we use for some type flexibility. E.g. in
as(obj[[varname]], 'numericMatrix'), the C++ implementation ofobj[[varname]]returns an ETaccessorBase (by unique_ptr).This PR provides a type on the R side called 'ETaccessor' and a symbol for symbolTables. It also supports returning these objects or taking them as arguments (which must be by reference, which is automatic).
Any method taking or returning one of these objects must not be interfaced through the generic interface to R because there is no
as<>orwrap<>conversion of the C++ type.This PR has passed tests already so I will merge soon.