Skip to content

Remove useless empty shell variable checks#420

Merged
nikobockerman merged 1 commit intomainfrom
cleanup-gha-shell-scripts
Feb 16, 2026
Merged

Remove useless empty shell variable checks#420
nikobockerman merged 1 commit intomainfrom
cleanup-gha-shell-scripts

Conversation

@nikobockerman
Copy link
Owner

These were initially added when shellcheck rules still required validating all environment variables. Since then capitalized environment variables are allowed with shellcheck to avoid bloated checks.

These were initially added when shellcheck rules still required
validating all environment variables. Since then capitalized environment
variables are allowed with shellcheck to avoid bloated checks.
Copilot AI review requested due to automatic review settings February 16, 2026 19:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes redundant environment variable validation checks from GitHub Actions shell scripts. These explicit checks are no longer needed because shellcheck rules have been updated to allow capitalized environment variables without requiring validation, and the scripts use set -u which causes immediate exit on undefined variable references.

Changes:

  • Removed validation checks for GitHub Actions environment variables (GITHUB_ENV, GITHUB_OUTPUT, RUNNER_OS, RUNNER_TEMP, GITHUB_WORKSPACE)
  • Removed validation checks for input variables (CACHE_MODE, MISE_VERSION)
  • Simplified the "Validate inputs" section to rely on bash's built-in undefined variable detection

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/actions/uv-project-setup/init.sh Removed redundant validation checks for GITHUB_ENV, GITHUB_OUTPUT, RUNNER_OS, RUNNER_TEMP, and CACHE_MODE
.github/actions/mise-project-setup/init.sh Removed redundant validation checks for GITHUB_ENV, GITHUB_OUTPUT, RUNNER_OS, RUNNER_TEMP, MISE_VERSION, and CACHE_MODE

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nikobockerman nikobockerman enabled auto-merge (squash) February 16, 2026 19:35
@nikobockerman nikobockerman merged commit ed2c405 into main Feb 16, 2026
57 checks passed
@nikobockerman nikobockerman deleted the cleanup-gha-shell-scripts branch February 16, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant