Remove useless empty shell variable checks#420
Merged
nikobockerman merged 1 commit intomainfrom Feb 16, 2026
Merged
Conversation
These were initially added when shellcheck rules still required validating all environment variables. Since then capitalized environment variables are allowed with shellcheck to avoid bloated checks.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes redundant environment variable validation checks from GitHub Actions shell scripts. These explicit checks are no longer needed because shellcheck rules have been updated to allow capitalized environment variables without requiring validation, and the scripts use set -u which causes immediate exit on undefined variable references.
Changes:
- Removed validation checks for GitHub Actions environment variables (GITHUB_ENV, GITHUB_OUTPUT, RUNNER_OS, RUNNER_TEMP, GITHUB_WORKSPACE)
- Removed validation checks for input variables (CACHE_MODE, MISE_VERSION)
- Simplified the "Validate inputs" section to rely on bash's built-in undefined variable detection
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/actions/uv-project-setup/init.sh | Removed redundant validation checks for GITHUB_ENV, GITHUB_OUTPUT, RUNNER_OS, RUNNER_TEMP, and CACHE_MODE |
| .github/actions/mise-project-setup/init.sh | Removed redundant validation checks for GITHUB_ENV, GITHUB_OUTPUT, RUNNER_OS, RUNNER_TEMP, MISE_VERSION, and CACHE_MODE |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were initially added when shellcheck rules still required validating all environment variables. Since then capitalized environment variables are allowed with shellcheck to avoid bloated checks.