Preserve castling rights for promoted kings on a SuicideBoard - #1202
Open
jacksonthall22 wants to merge 2 commits into
Open
Preserve castling rights for promoted kings on a SuicideBoard#1202jacksonthall22 wants to merge 2 commits into
SuicideBoard#1202jacksonthall22 wants to merge 2 commits into
Conversation
…rights-hotfix Preserve castling rights when a promoted king moves
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a
SuicideBoard, you can promote to a king, but when a promoted king moves, current code incorrectly removes castling rights unilaterally even if the original king and rooks haven't moved:Fixes that and adds a regression test.
Funnily enough, Antichess on Lichess forbids castling outright. Not sure what the history of Antichess vs. Suicide Chess is and what the behavior here should be, or if
python-chessshould support a separate Antichess variant board... but in any case I was confused when I also could not reproduce the expected behavior on Lichess - notice that loading this link withKQcastling rights specified in the URL just strips them in theFENbox on the page 😂