Skip to content

chore: updated GH runners#70

Open
nick4eva wants to merge 4 commits into
masterfrom
update-gh-runners
Open

chore: updated GH runners#70
nick4eva wants to merge 4 commits into
masterfrom
update-gh-runners

Conversation

@nick4eva
Copy link
Copy Markdown
Owner

@nick4eva nick4eva commented Dec 30, 2025

PR Type

Enhancement


Description

  • Updated GitHub Actions runners from Ubuntu 20.04 to 24.04

  • Modernized CI/CD pipeline with latest Ubuntu LTS version

  • Removed outdated Ubuntu 20.04 from test matrix

  • Standardized all workflow jobs to use Ubuntu 24.04


Diagram Walkthrough

flowchart LR
  A["Ubuntu 20.04"] -->|"upgrade"| B["Ubuntu 24.04"]
  C["lint.yml"] -->|"updated"| B
  D["test.yml"] -->|"updated"| B
Loading

File Walkthrough

Relevant files
Configuration changes
lint.yml
Upgrade lint workflow runners to Ubuntu 24.04                       

.github/workflows/lint.yml

  • Updated all four job runners from ubuntu-20.04 to ubuntu-24.04
  • Affected jobs: actionlint, shellcheck, markdownlint, hadolint
  • Maintains existing workflow structure and dependencies
+4/-4     
test.yml
Update test matrix to Ubuntu 24.04                                             

.github/workflows/test.yml

  • Removed ubuntu-20.04 from test matrix
  • Added ubuntu-24.04 to test matrix
  • Kept ubuntu-22.04 in the matrix for compatibility
+1/-1     

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review Bot commented Dec 30, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review Bot commented Dec 30, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Replace deprecated and unmaintained action

Replace the deprecated and unmaintained reviewdog/action-markdownlint action
with a maintained alternative like davidanson/markdownlint-cli2-action to
improve security and compatibility.

.github/workflows/lint.yml [39]

-uses: reviewdog/action-markdownlint@v0
+uses: davidanson/markdownlint-cli2-action@v16

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 9

__

Why: This suggestion correctly identifies the use of a deprecated and unmaintained action, which poses a significant security and compatibility risk, and provides a suitable replacement.

High
General
Pin action version for stability
Suggestion Impact:The workflow was updated to pin ludeeus/action-shellcheck from @master to a fixed version (@2.0.0), addressing the stability concern (though using a specific patch version rather than the example @v2 tag).

code diff:

       - name: Run ShellCheck
-        uses: ludeeus/action-shellcheck@master
+        uses: ludeeus/action-shellcheck@2.0.0
         with:

Pin the ludeeus/action-shellcheck action to a specific version tag (e.g., @v2)
instead of @master to ensure workflow stability and prevent unexpected breaking
changes.

.github/workflows/lint.yml [27]

-uses: ludeeus/action-shellcheck@master
+uses: ludeeus/action-shellcheck@v2

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies a potential stability issue by using @master for a GitHub Action and proposes a valid fix, which is a recommended best practice.

Low
  • Update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant