Add fingerprint authentication support via AuthPrompt signals - #28
Draft
nestor-lobo-work wants to merge 1 commit into
Draft
Conversation
Listen to the lock dialog's AuthPrompt 'next' signal to detect when fingerprint verification is active (e.g. 'Place your finger' message), triggering the same blur/pause effects as the password prompt. Also hooks into _onVerificationComplete to apply prompt effects during successful fingerprint unlock transitions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Owner
|
Hi @nestor-lobo-work, and thanks for your contribution! Unfortunately, I can't verify whether it works since I don't have a fingerprint scanner to test it with. That said, after looking through the code, I noticed a few issues. In particular, If it genuinely works as expected on your setup, and you remove the redundant code, I'll merge it into the main branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The extension's blur/pause effects only activate when the password prompt is shown, but GNOME's lock screen also supports fingerprint authentication via
fprintd. Users with fingerprint readers don't get the visual effects during biometric verification.Approach
Hooks into the lock dialog's
AuthPromptsignals to detect fingerprint activity:authPrompt.nextsignal -- fires when the auth prompt transitions to fingerprint verification (e.g. "Place your finger on the reader"), triggering the same_onPromptShow()blur/pause effects as the password prompt._onVerificationCompleteoverride -- ensures prompt effects apply during a successful fingerprint unlock transition before the screen fully unlocks.authPromptsignals indisable()to avoid leaks.This means fingerprint auth now behaves identically to password auth regarding all prompt-related settings (blur change, pause, grayscale).