codegen: handle S160 multidimensional input size using array.size#2166
Open
codegen: handle S160 multidimensional input size using array.size#2166
Conversation
rahur-NI
requested review from
marcoskirsch,
ni-jfitzger and
vnktshr21
as code owners
vnktshr21
reviewed
Feb 25, 2026
| S130. Input enum: visatype.ViInt32(parameter_name.value) | ||
| S150. Input scalar: visatype.ViInt32(parameter_name) | ||
| S160. Input is size of input buffer: visatype.ViInt32(0 if list is None else len(list)) | ||
| S160. Input is size of input buffer: visatype.ViInt32(0 if list is None else len(list)) or visatype.ViInt32(0 if array is None else array.size) |
Collaborator
There was a problem hiding this comment.
@ni-jfitzger , should we add a new code for this case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated CHANGELOG.md if applicable.What does this Pull Request accomplish?
This PR fixes the S160 size-parameter codegen path for input buffers so multidimensional arrays use total element count instead of first-dimension length.
Before this fix, S160 used len(array_name), which undercounted multidimensional inputs by returning only the first dimension; now it uses array_name.size when array_dimensions > 1 and preserves existing len(array_name) behavior for 1D/default inputs.
List issues fixed by this Pull Request below, if any.
What testing has been done?