Update USP docs under keepalive connections for better readability#2168
Open
Morgan-P-04 wants to merge 1 commit into
Open
Update USP docs under keepalive connections for better readability#2168Morgan-P-04 wants to merge 1 commit into
Morgan-P-04 wants to merge 1 commit into
Conversation
✅ Deploy Preview will be available once build job completes!
|
shaun-nx
approved these changes
Jul 24, 2026
y82
approved these changes
Jul 24, 2026
salonichf5
approved these changes
Jul 24, 2026
Contributor
|
Just for the sake of the guide, since the default nginx keepalive is 32, can we adjust the guide example so the USP isn't setting the keepalive to 32, but instead perhaps 24? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR updates the
Enable keepalive connectionssection of the Upstream Settings Policy API to improve the readability for users. The change re-orders where the default value for thekeepalivedirective is mentioned so that users do not have to switch context as much, to align with a suggestion from the team: #2160 (comment)Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩