Fix compile errors in the server and client.#38
Open
husafan wants to merge 1 commit intonfultz:masterfrom
Open
Fix compile errors in the server and client.#38husafan wants to merge 1 commit intonfultz:masterfrom
husafan wants to merge 1 commit intonfultz:masterfrom
Conversation
The client needs to define the type of struct since instances were already allocated in the definition of the grpc_metadata array. Also, the default nullptr's can be removed from the nested obfuscated struct's creation in the same statement. The server needs to undef the Free macro defined by Rcpp so it can be defined by absl low_level_alloc later.
Owner
|
Can you add to your post which version this fix is for? eg output of |
Author
|
Done. I've added the grpc, Ubuntu and gcc versions. Please feel free to not merge this if it doesn't repro. I have it working in my project now, so no rush. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client needs to define the type of struct since instances were already allocated in the definition of the grpc_metadata array. Also, the default nullptr's can be removed from the nested obfuscated struct's creation in the same statement.
The server needs to undef the Free macro defined by Rcpp so it can be defined by absl low_level_alloc later.
These changes were tested against grpc version 1.41.1 (12a4a6f8c06b96e38f8576ded76d0b79bce13efd7560ed22134c2f433bc496ad) on Ubuntu 21.04 with gcc (Ubuntu 10.3.0-1ubuntu1) 10.3.0.
Fixes #37