parse container registries from .nf-core.yml#4282
Open
mashehu wants to merge 5 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| ```yaml | ||
| repository_type: pipeline | ||
| nf_core_version: "3.2.0" |
Contributor
There was a problem hiding this comment.
set to a more recent version?
Suggested change
| nf_core_version: "3.2.0" | |
| nf_core_version: "4.0.3" |
| branch: str | None = None, | ||
| no_pull: bool = False, | ||
| registry: str | None = None, | ||
| registry: str = "quay.io,community.wave.seqera.io/library/", |
Contributor
There was a problem hiding this comment.
Maybe just pass as tuple[str] directly?
Also be consistent with trailing slashes.
Suggested change
| registry: str = "quay.io,community.wave.seqera.io/library/", | |
| registries: tuple[str] = ("quay.io/", "community.wave.seqera.io/library/"), |
| branch: str | None = None, | ||
| no_pull: bool = False, | ||
| registry: str | None = None, | ||
| registry: str = "quay.io,community.wave.seqera.io/library/", |
Contributor
There was a problem hiding this comment.
Changing the type to tuple[str] would effect this as well.
| else: | ||
| self.registry = registry | ||
| log.debug(f"Registry set to {self.registry}") | ||
| def _set_registry(self, registry: str) -> None: |
Contributor
There was a problem hiding this comment.
Changing to registry: tuple[str] would effect this as well.
JulianFlesch
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only works in module repos
Also adds a bit more API docs for the different pydantic models