Skip to content

Add quilt2 first draft implementation#282

Open
atrigila wants to merge 19 commits intonf-core:devfrom
atrigila:quilt2
Open

Add quilt2 first draft implementation#282
atrigila wants to merge 19 commits intonf-core:devfrom
atrigila:quilt2

Conversation

@atrigila
Copy link
Copy Markdown
Collaborator

@atrigila atrigila commented Apr 3, 2026

Closes #116

@atrigila atrigila marked this pull request as ready for review April 12, 2026 22:13
@atrigila atrigila requested a review from LouisLeNezet April 12, 2026 22:13
Copy link
Copy Markdown
Collaborator

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest a few changes to make this integration similar to all the other tools used at the moment.

Comment thread conf/steps/imputation_quilt2.config Outdated
Comment thread conf/test_quilt2.config
Comment thread docs/usage.md
Comment on lines +545 to +547
#### `quilt`

The required inputs for `quilt` are BAM/CRAM samples provided in the input samplesheet (`--input`) and a CSV file with the genomic chunks (`--chunks`).
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a similar part for quilt2 ?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sbwf should be in nf-core as all the other one.

Comment thread workflows/phaseimpute/tests/nextflow.config Outdated
Comment thread workflows/phaseimpute/tests/test_quilt2.nf.test Outdated
Comment thread README.md Outdated
atrigila and others added 5 commits April 15, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants