Skip to content

Methurator update#12398

Merged
edogiuili merged 4 commits into
nf-core:masterfrom
edogiuili:methurator_update
Jul 22, 2026
Merged

Methurator update#12398
edogiuili merged 4 commits into
nf-core:masterfrom
edogiuili:methurator_update

Conversation

@edogiuili

Copy link
Copy Markdown
Contributor

In this PR, I bumped the container/conda versions. I also removed the --compute_ci parameter from the methurator/gtestimator module, since it can cause some test samples to fail (see here).

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@edogiuili
edogiuili enabled auto-merge July 22, 2026 07:08
@edogiuili
edogiuili added this pull request to the merge queue Jul 22, 2026
Merged via the queue into nf-core:master with commit 2789ce9 Jul 22, 2026
26 checks passed
@edogiuili
edogiuili deleted the methurator_update branch July 22, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants