Skip to content

Modify inputs in rclone check and checksum#12394

Merged
delfiterradas merged 8 commits into
nf-core:masterfrom
delfiterradas:update_rclone
Jul 22, 2026
Merged

Modify inputs in rclone check and checksum#12394
delfiterradas merged 8 commits into
nf-core:masterfrom
delfiterradas:update_rclone

Conversation

@delfiterradas

@delfiterradas delfiterradas commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Closes nf-core/datasync#52:

  • Accept rclone cofig
  • Set inputs to be val instead of path, to avoid staging of files
  • Capture exit codes
  • Remove empty files from output

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@delfiterradas delfiterradas self-assigned this Jul 21, 2026
@delfiterradas
delfiterradas requested a review from atrigila July 22, 2026 13:14
@atrigila
atrigila removed their request for review July 22, 2026 13:21

@itrujnara itrujnara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes are fine, just some small comments to consider

Comment thread modules/nf-core/rclone/checksum/tests/main.nf.test Outdated
}
}

test("missing destination") {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test not meaningful anymore?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work anymore since now that the files are not staged it only accepts directories, not files. Also it won't be able to list the files in https://raw.githubusercontent.com directories. This scenario is now included in "test - md5 - differs".

@delfiterradas
delfiterradas added this pull request to the merge queue Jul 22, 2026
Merged via the queue into nf-core:master with commit a554e54 Jul 22, 2026
1 check passed
@delfiterradas
delfiterradas deleted the update_rclone branch July 22, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify input in rclone_check and rclone_checksum to take rclone config

4 participants