Skip to content

Add ciri2 module#12224

Open
razmia02 wants to merge 7 commits into
nf-core:masterfrom
razmia02:add_ciri2_module
Open

Add ciri2 module#12224
razmia02 wants to merge 7 commits into
nf-core:masterfrom
razmia02:add_ciri2_module

Conversation

@razmia02

@razmia02 razmia02 commented Jul 1, 2026

Copy link
Copy Markdown

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@atrigila atrigila added the draft label Jul 2, 2026
@razmia02
razmia02 force-pushed the add_ciri2_module branch from c061f20 to 239f66b Compare July 2, 2026 21:54
@razmia02
razmia02 marked this pull request as ready for review July 22, 2026 20:13
@razmia02

Copy link
Copy Markdown
Author

This PR is ready for review. Passed nf-core modules test.
For test data: CIRI2 specifically requires unsorted sam files generated by bwa-mem with -T 19 flag. Although I have tested the module with alreday available testdata from nf-core repo, I have also submitted PR for the CIRI2's own test data.
Test data PR: https://github.com/nf-core/test-datasets/pull/2159.

@mashehu

mashehu commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Please join the github org via the slack channel so the CI runs for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants