Conversation
CarlSchwan
force-pushed
the
carl/port-deprecated
branch
from
5b422f5 to
a306dbc
Compare
Member
|
Thank you! |
OC_Util is on the way out Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
…on includes them, trust the unit/integration tests to spot issues with the new methods/classes Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
carl/port-deprecated
branch
from
a306dbc to
ba4d3db
Compare
Member
|
I hope you don't mind: I have rebased this branch on main and added a fix suggestion. Since we have the unit/integrations tests that are supposed to fail if we use missing classes/methods, it seems fine to just ignore the |
Member
Author
|
Thanks for rebassing, looks fine to me |
julien-nc
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep old compatibility for now, but at least allow us to drop some OC_Util methods at some point