Skip to content

fix(ImageView): use cursor: pointer for clickable items #8813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mejo- wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −4
Open

fix(ImageView): use cursor: pointer for clickable items #8813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/nodes/ImageView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@
<div
v-if="isMediaAttachment"
contenteditable="false"
class="media"
@click="handleAttachmentClick">
<div class="media__wrapper">
class="media">
<div
class="media__wrapper clickable"
@click="handleAttachmentClick">
Comment on lines +27 to +29

@max-nextcloud max-nextcloud Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using an <a> tag instead. That seems semantically closer to what the element is.
The href could even point to the url handleAttachmentClick opens if it does not open the viewer.

<img
v-show="loaded"
:src="imageUrl"
Expand Down Expand Up @@ -53,7 +54,7 @@
v-show="loaded"
:src="imageUrl"
:alt="alt"
class="image__main"
class="image__main clickable"

@max-nextcloud max-nextcloud Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also turn the surounding <div> into an <a> and move the click handler there?

@click="handleImageClick"
@load="onLoaded" />
</div>
Expand Down Expand Up @@ -552,6 +553,14 @@ export default {
justify-content: left;
padding-bottom: 0;

.clickable {
cursor: pointer;

* {
cursor: pointer;
}
}

.media__wrapper {
display: flex;
border: 2px solid var(--color-border);
Expand Down Expand Up @@ -579,6 +588,7 @@ export default {
}
}
}

.buttons {
margin-left: 8px;
}
Expand Down
Loading