Skip to content

⚒️🎨 Migrate to ModalBottomSheet Composable#6008

Merged
AndyScherzinger merged 15 commits intomasterfrom
style/noid/convListModalBottomSheet
Apr 5, 2026
Merged

⚒️🎨 Migrate to ModalBottomSheet Composable#6008
AndyScherzinger merged 15 commits intomasterfrom
style/noid/convListModalBottomSheet

Conversation

@AndyScherzinger
Copy link
Copy Markdown
Member

@AndyScherzinger AndyScherzinger commented Mar 27, 2026 •
edited
Loading

🖼️ Screenshots

🏡 conv-list 🏡 scope 🏡 status 🏡 status-message
Screenshot_20260327_183533 Screenshot_20260328_095039 Screenshot_20260328_182652 Screenshot_20260328_182704

🚧 TODO

  • review & merge

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added this to the 23.1.0 milestone Mar 27, 2026
@AndyScherzinger AndyScherzinger requested a review from mahibi March 27, 2026 17:37
@AndyScherzinger AndyScherzinger added design Related to the design 3. to review Waiting for reviews technical debt Technical issue labels Mar 27, 2026
@AndyScherzinger AndyScherzinger changed the title style: Migrate to ModalBottomSheet Composable ⚒️🎨 Migrate to ModalBottomSheet Composable Mar 27, 2026
@AndyScherzinger AndyScherzinger force-pushed the style/noid/convListModalBottomSheet branch 6 times, most recently from dd40784 to 94b6f45 Compare March 28, 2026 17:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 28, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/23692036400/artifacts/6160568525
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@nextcloud nextcloud deleted a comment from github-actions bot Mar 29, 2026
@nextcloud nextcloud deleted a comment from github-actions bot Mar 29, 2026
@nextcloud nextcloud deleted a comment from github-actions bot Mar 29, 2026
@nextcloud nextcloud deleted a comment from github-actions bot Mar 29, 2026
@nextcloud nextcloud deleted a comment from github-actions bot Mar 29, 2026
@nextcloud nextcloud deleted a comment from github-actions bot Mar 29, 2026
@AndyScherzinger AndyScherzinger force-pushed the style/noid/convListModalBottomSheet branch 3 times, most recently from 9a5dedf to 09af52b Compare March 29, 2026 10:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 29, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/23706968551/artifacts/6165193866
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@mahibi mahibi force-pushed the style/noid/convListModalBottomSheet branch from 09af52b to dc6aa10 Compare April 2, 2026 16:02
@mahibi
Copy link
Copy Markdown
Collaborator

mahibi commented Apr 2, 2026 •
edited by AndyScherzinger
Loading

works good. just some minor things:

@AndyScherzinger AndyScherzinger force-pushed the style/noid/convListModalBottomSheet branch from dc6aa10 to d22ae9b Compare April 4, 2026 16:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/23983056183/artifacts/6271949054
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger
style: Migrate conversation list actions to ModalBottomSheet Composable
61f08a7 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
style: Migrate scope dialog to ModalBottomSheet Composable
652923f 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
style: Migrate user status dialog to ModalBottomSheet Composable
5a1f27f 
AI-assistant: Copilot 1.0.10 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
style(scope): make scope list scrollable
cd85e6d 
...shorten previews code

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
ci(lint): Remove unused resources
b0fd620 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
ci(codacy): Split Composable and move previews to own file
4e8a2f9 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the style/noid/convListModalBottomSheet branch from d22ae9b to 4e8a2f9 Compare April 4, 2026 18:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/23985365199/artifacts/6272597553
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger
fix(conv-list): refresh list when archiving/unarchiving a conversation
271b380 
AI-assistant: Copilot 1.7.1-243 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/23985687372/artifacts/6272685752
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger
fix: Move state to view model, ensure scrolling is possible
5227ede 
AI-assistant: Copilot 1.7.1-243 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/23985868422/artifacts/6272733540
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger
fix: Have a state for the account chooser dialog and for the status b…
dc85a89 
…ottoms sheets to survive screen rotations

AI-assistant: Copilot 1.7.1-243 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix: Have a state for the item visibility bottom sheet
0321dac 
AI-assistant: Copilot 1.7.1-243 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/24000520232/artifacts/6277028703
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/24002130692/artifacts/6277489719
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger
feat: Move to coroutines
46c0a5f 
AI-assistant: Copilot 1.7.1-243 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the style/noid/convListModalBottomSheet branch from cf72063 to 46c0a5f Compare April 5, 2026 13:36
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/24002655591/artifacts/6277638663
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger
fix(detekt): Have max 15 functions
c44087c 
AI-assistant: Copilot 1.7.1-243 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/24003110707/artifacts/6277772928
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger
feat: Migrate reactions to ModalBottomSheet
3ec4024 
AI-assistant: Copilot 1.7.1-243 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/24005534706/artifacts/6278484050
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger
ci(lint): Lower score to 88
cef48e7 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger mentioned this pull request Apr 5, 2026
Open
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/24005816027/artifacts/6278558576
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger
chore: Move reaction bottom sheet to chat package
937eb95 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

APK file: https://github.com/nextcloud/talk-android/actions/runs/24006276294/artifacts/6278694019
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

Codacy

Lint

TypemasterPR
Warnings9088
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5353
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8080

@AndyScherzinger AndyScherzinger merged commit 6d425ad into master Apr 5, 2026
16 of 17 checks passed
@AndyScherzinger AndyScherzinger deleted the style/noid/convListModalBottomSheet branch April 5, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi Awaiting requested review from mahibi

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

Assignees

No one assigned

Labels

3. to review Waiting for reviews design Related to the design technical debt Technical issue

Projects

None yet

Milestone

24.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@AndyScherzinger @mahibi