Skip to content

Conversation

@rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Jan 21, 2026

  • Fixed UI for dark mode
  • Moved the Pinned View to it's own file

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot 2026-01-21 at 8 36 26 AM Screenshot 2026-01-21 at 8 28 06 AM
Screenshot 2026-01-21 at 8 35 51 AM Screenshot 2026-01-21 at 8 29 01 AM

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 requested a review from mahibi January 21, 2026 14:36
@rapterjet2004 rapterjet2004 self-assigned this Jan 21, 2026
@rapterjet2004 rapterjet2004 added the 3. to review Waiting for reviews label Jan 21, 2026
…for dark mode

Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004 rapterjet2004 force-pushed the issue-5717-fix-pinned-darkmode branch from 1b3edae to 5b72a06 Compare January 21, 2026 15:30
@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5737.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9999
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jan 21, 2026

For further polishing we might want to to make the menu headline bold else it currenrly looks like a menu item without an icon followed by a divider but the time info is not clickable. Else I think it could also be an option to put the time into the pinned message field also.

Not sure what you think of or prefer @nimishavijay

Could well be a follow up of course since it isn't related to the dark mode issue.

@AndyScherzinger AndyScherzinger added this to the 23.0.0 milestone Jan 21, 2026
@mahibi mahibi merged commit 76ba091 into master Jan 22, 2026
15 of 17 checks passed
@mahibi mahibi deleted the issue-5717-fix-pinned-darkmode branch January 22, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dark mode issues with message pinning

4 participants