Skip to content

Fix respect view column order in public sharing#2701

Open
taiebot wants to merge 5 commits into
nextcloud:mainfrom
taiebot:Fix-view-6
Open

Fix respect view column order in public sharing#2701
taiebot wants to merge 5 commits into
nextcloud:mainfrom
taiebot:Fix-view-6

Conversation

@taiebot

@taiebot taiebot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

At the moment filtered views are not sorted as per the view column order if you share them pubicly
with this PR they are sorted and respect the table order. this will fix #2595

Screenshot of private view
image

in public sorted
image

with an other order.
image

@taiebot taiebot requested review from blizzz and enjeck as code owners June 5, 2026 19:24
@AndyScherzinger AndyScherzinger added enhancement New feature or request 3. to review Waiting for reviews AI assisted and removed AI assisted labels Jun 6, 2026
@AndyScherzinger AndyScherzinger added this to the v2.3.0 milestone Jun 6, 2026

@enjeck enjeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, except for the linting errors. Can be fixed by running npm run lint:fix

@enjeck

enjeck commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Also, need to sign commits to fix DCO: https://github.com/nextcloud/tables/pull/2701/checks?check_run_id=81362784234

@enjeck

enjeck commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

hmm, seems like we still need to run npm run lint:fix

Signed-off-by: taiebot <dedreuil@yahoo.fr>
@enjeck

enjeck commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

hmm, seems like we still need to run npm run lint:fix

weird how it's still failing 🤔

Had to force the indentation by resetting everything to zero. Looks like it is working now. I had some errors yesterday but did not think of doing this

Signed-off-by: taiebot <dedreuil@yahoo.fr>
@taiebot

taiebot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

Hopefully all good now. Sorry not used to those CI shenanigans

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted enhancement New feature or request feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Embedded and shared tables do not respect the view column order

3 participants