Skip to content

Update URL validation for text-link column#2452

Merged
blizzz merged 1 commit intomainfrom
update-text-link-validation
May 6, 2026
Merged

Update URL validation for text-link column#2452
blizzz merged 1 commit intomainfrom
update-text-link-validation

Conversation

@luka-nextcloud
Copy link
Copy Markdown
Contributor

No description provided.

enjeck
enjeck previously requested changes Apr 11, 2026
Copy link
Copy Markdown
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some links like javascript:https://openai.com are accepted.

Also, in the frontend, we have isValidUrlProtocol() for validating the url, and it would be nice if we have similar logic for the backend too

@AndyScherzinger AndyScherzinger added the 3. to review Waiting for reviews label Apr 12, 2026
@enjeck enjeck added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 24, 2026
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@luka-nextcloud luka-nextcloud force-pushed the update-text-link-validation branch from 03f9bbf to 84c07e0 Compare April 28, 2026 09:46
@luka-nextcloud luka-nextcloud requested a review from enjeck May 4, 2026 20:32
@blizzz blizzz dismissed enjeck’s stale review May 6, 2026 12:46

pointed out issue was addressed

@blizzz blizzz merged commit 236d8eb into main May 6, 2026
66 checks passed
@blizzz blizzz deleted the update-text-link-validation branch May 6, 2026 12:46
@blizzz
Copy link
Copy Markdown
Member

blizzz commented May 6, 2026

/backport to stable1.0

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label May 6, 2026
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants