feat(reply_private): Enhance reply private quote#17069
feat(reply_private): Enhance reply private quote#17069nickvergessen merged 6 commits intonextcloud:mainfrom
Conversation
937632d to
a5f1098
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
a5f1098 to
c6f1772
Compare
Antreesy
left a comment
There was a problem hiding this comment.
Please split your changes into at least three commits for readability:
- PHP changes
- regenerated openapi files (json ans ts)
- Frontend changes
ff89ef6 to
569561e
Compare
Have done this. Kindly re-review and let me know if all your existing comments are addressed and test cases work. |
nickvergessen
left a comment
There was a problem hiding this comment.
Some small comments, but mostly fine backend-wise.
Would be good to have integration tests, but can also do that in a follow up
569561e to
bcdfded
Compare
I would like to take this as a follow-up as this PR got already big enough. Addressed all the comments, otherwise :) |
Antreesy
left a comment
There was a problem hiding this comment.
I really like the feature, but it should have a good ground to continue maintain and build from (e.g. we can use the same approach later to forward messages). At the moment I'm not fond of constructing the message object on client side, esp. if it breaks older and mobile clients
d7f4bf2 to
2f02f48
Compare
Have made all UI changes on top of @nickvergessen 's API change. Let me know if this is good to go now @Antreesy |
Antreesy
left a comment
There was a problem hiding this comment.
Mostly minor comments from frontend side. Otherwise works fine, even render on old clients seems acceptable to me (visible text, non-working link is ok)
Regarding visual - we can discuss with designers and take over a follow-up after merge. I think we shouldn't show the full message, 2-3 lines can be enough
2f02f48 to
6fcde7a
Compare
Antreesy
left a comment
There was a problem hiding this comment.
Last iteration, I hope. Noticed a couple of things to pay attention to and revert leftovers from previous chages, otherwise that's a green light from me =)
6fcde7a to
d3f82d4
Compare
This is done |
adaf1a1 to
6575b43
Compare
Signed-off-by: existentialcoder <shravanayyappa@gmail.com>
Signed-off-by: existentialcoder <shravanayyappa@gmail.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
☑️ Resolves
🖌️ UI Checklist
privatereplyby passing theparentTokenfor a new message send and schedule🖼️ Screenshots / Screencasts
https://streamable.com/9e1rzv
🏁 Checklist
🛠️ API Checklist
🚧 Tasks
replyToTokenonsendMessageandscheduleMessageonChatControllerprivate_replyto store all the parent details🏁 Checklist
docs/has been updated or is not required