chore(OC_App): migrate more legacy function and usage#60071
Open
chore(OC_App): migrate more legacy function and usage#60071
Conversation
susnux
added
3. to review
…o AppManager Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/legacy
branch
2 times, most recently
from
5c53a18 to
031c44c
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
leftybournes,
nfebe,
salmart-dev and
sorbaugh
and removed request for
a team
artonge
reviewed
May 6, 2026
| * @param bool $ignoreMax - Whether to ignore the Nextcloud max version requirement | ||
| * @throws \Exception - If there are missing dependencies | ||
| */ | ||
| public function checkAppDependencies(string $appId, bool $ignoreMax = false): void { |
Collaborator
There was a problem hiding this comment.
Should those methods be announced in the IAppManager interface?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move more functions to AppManager that still make sense to be shared.
Moreover usage is migrated to AppManager instead of legacy
OC_App.Checklist
3. to review, feature component)stable32)AI (if applicable)