Skip to content

test(AmazonS3): add batchDelete test (>1000) #58579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joshtrichards wants to merge 2 commits into
base: master
Choose a base branch
from
+38 −0
Draft

test(AmazonS3): add batchDelete test (>1000) #58579

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c101483
test(AmazonS3): add batchDelete test (>1000)
joshtrichards Feb 25, 2026
483980f
chore: fixup Amazons3Test.php
joshtrichards Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions apps/files_external/tests/Storage/Amazons3Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,42 @@ protected function tearDown(): void {
public function testStat(): void {
$this->markTestSkipped('S3 doesn\'t update the parents folder mtime');
}

/**
* Test rmdir() with a directory containing more than 1000 files to validate S3 batchDelete logic.
*/
public function testRmdirManyFiles() {
$dir = 'bigDir';
$numFiles = 1100; // S3 batchDelete limit is 1000

// Create the directory
$this->assertTrue($this->instance->mkdir($dir));

// Create 1100 files inside the directory
for ($i = 0; $i < $numFiles; $i++) {
$filePath = $dir . '/file' . $i . '.txt';
$this->assertNotFalse(
$this->instance->file_put_contents($filePath, 'test content'),
"Failed to create file: $filePath"
);
}

$this->wait();
// Confirm directory and files exist
$this->assertTrue($this->instance->is_dir($dir));
$this->assertTrue($this->instance->file_exists($dir . '/file0.txt'));
$this->assertTrue($this->instance->file_exists($dir . '/file1099.txt'));

// Delete the directory (should trigger multi-batchDelete in S3)
$this->assertTrue(
$this->instance->rmdir($dir),
'rmdir failed on bigDir with many files'
);

$this->wait();
// Confirm directory and files are deleted
$this->assertFalse($this->instance->file_exists($dir));
$this->assertFalse($this->instance->file_exists($dir . '/file0.txt'));
$this->assertFalse($this->instance->file_exists($dir . '/file1099.txt'));
}
}
Loading