handle case where we can't get the filesize after open in dav get#58550
Open
icewind1991 wants to merge 1 commit intomasterfrom
Open
handle case where we can't get the filesize after open in dav get#58550icewind1991 wants to merge 1 commit intomasterfrom
icewind1991 wants to merge 1 commit intomasterfrom
Conversation
icewind1991
requested review from
Altahrim,
ArtificialOwl,
artonge and
come-nc
and removed request for
a team
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
dav-open-size-not-found
branch
from
04eaca0 to
9d7d562
Compare
susnux
approved these changes
Feb 24, 2026
| if ($this->getSize() !== $fsSize) { | ||
| $logger = Server::get(LoggerInterface::class); | ||
| if ($fsSize === false) { | ||
| $logger->warning('file not found on storage after successfully opening it'); |
Contributor
There was a problem hiding this comment.
Does it make sense (for proper client error code) to throw a StorageNotAvailableException here?
Member
Author
There was a problem hiding this comment.
Given that the file opened successfully, I'm not sure if we should return an error or just try to read the handle we got an hope that that gives the correct content.
We don't really have enough info to determine that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires