Active share validation/authoritative mount improvements by icewind1991 · Pull Request #57760 · nextcloud/server

icewind1991 · 2026-01-23T15:03:32Z

For events where we know the share, only check/register mount for that share
Above a certain number of users, postpone the checks till fs setup time for the user

…s for new share" Signed-off-by: Joas Schilling <coding@schilljs.com>

Signed-off-by: Joas Schilling <coding@schilljs.com>

apps/files_sharing/lib/Config/ConfigLexicon.php

apps/files_sharing/lib/Listener/SharesUpdatedListener.php

provokateurin

The last commit should be backported as a bug fix

lib/public/Files/Events/UserHomeSetupEvent.php

provokateurin · 2026-02-19T07:12:29Z

apps/files_sharing/lib/ShareRecipientUpdater.php

+
+		$shares = $this->shareMountProvider->getSuperSharesForUser($user, $ignoreShares);
+
+		$mountsChanged = count($shares) !== count($shareMounts);


What does this mean? Should it be set to default, given that the loop might set it to true?

Added a comment

artonge · 2026-02-20T15:51:53Z

lib/private/Files/Config/UserMountCache.php


 		try {
 			$query->executeStatement();
+			unset($this->mountsForUsers[$user->getUID()]);


Why do we need to reset the mounts for a user when adding a new one?

Because otherwise getMountsForUsers will return the old results

But can't we only add the new mount?

lib/private/Files/Config/UserMountCache.php

artonge · 2026-02-20T17:39:38Z

apps/files_sharing/lib/Listener/SharesUpdatedListener.php

+			foreach ($this->shareManager->getUsersForShare($share) as $user) {
+				if ($share->getSharedBy() !== $user->getUID()) {
+					$start = floatval($this->clock->now()->format('U.u'));
+					if ($this->cutOffMarkTime === -1.0 || $this->updatedTime < $this->cutOffMarkTime) {


So that cutOffMarkTime can be 0 and we can go straight to updating.
By the way, I am not sure whether it makes sense to try to update as many users as possible here instead of flagging them. Do we have more information now compared to later?

Suggested change

if ($this->cutOffMarkTime === -1.0 || $this->updatedTime < $this->cutOffMarkTime) {

if ($this->cutOffMarkTime === -1.0 || $this->updatedTime <= $this->cutOffMarkTime) {

So that cutOffMarkTime can be 0 and we can go straight to updating.

This is already the case.

Do we have more information now compared to later?

Yes, for the single-share-add case, possibly in the future for the single-share delete or transfer cases.

Now also for the delete case

Signed-off-by: Robin Appelman <robin@icewind.nl>

…number of users Signed-off-by: Robin Appelman <robin@icewind.nl>

Signed-off-by: Robin Appelman <robin@icewind.nl>

icewind1991 added this to the Nextcloud 34 milestone Jan 23, 2026

icewind1991 added the 3. to review Waiting for reviews label Jan 23, 2026

icewind1991 requested a review from a team as a code owner January 23, 2026 15:03

icewind1991 requested review from Altahrim, ArtificialOwl, nfebe and salmart-dev and removed request for a team January 23, 2026 15:03

artonge mentioned this pull request Jan 23, 2026

Authoritative Mountpoints #54563

Open

icewind1991 force-pushed the share-update-check-single branch from b1a28af to 054c5c0 Compare January 23, 2026 15:19

nickvergessen added a commit to nextcloud/spreed that referenced this pull request Jan 23, 2026

test: Run tests from nextcloud/server#57760 "fix: only validate mount…

095ab2e

…s for new share" Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen added a commit to nextcloud/spreed that referenced this pull request Jan 23, 2026

test: Run tests from nextcloud/server#57760 "fix: only validate mount…

46f7a27

…s for new share" Signed-off-by: Joas Schilling <coding@schilljs.com>

icewind1991 force-pushed the share-update-check-single branch from 054c5c0 to 3e548a5 Compare January 23, 2026 15:32

CarlSchwan approved these changes Jan 26, 2026

View reviewed changes

nickvergessen mentioned this pull request Jan 27, 2026

test: Run tests from nextcloud/server#57760 "fix: only validate mount… nextcloud/spreed#16833

Closed

icewind1991 force-pushed the share-update-check-single branch from 3e548a5 to 4851386 Compare February 5, 2026 13:48

nickvergessen added a commit to nextcloud/spreed that referenced this pull request Feb 5, 2026

test: Run tests against nextcloud/server#57760 share-update-check-single

4dee540

Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen mentioned this pull request Feb 5, 2026

test: Run tests against nextcloud/server#57760 share-update-check-single nextcloud/spreed#16987

Draft

nickvergessen added a commit to nextcloud/spreed that referenced this pull request Feb 6, 2026

test: Run tests against nextcloud/server#57760 share-update-check-single

b303266

Signed-off-by: Joas Schilling <coding@schilljs.com>

icewind1991 force-pushed the share-update-check-single branch 2 times, most recently from 000d868 to 716d880 Compare February 9, 2026 15:48

icewind1991 changed the title ~~fix: only validate mounts for new share~~ Active share validation improvements Feb 12, 2026

icewind1991 marked this pull request as draft February 12, 2026 14:09

icewind1991 force-pushed the share-update-check-single branch 2 times, most recently from b35ead2 to 8e50698 Compare February 17, 2026 13:54

icewind1991 changed the title ~~Active share validation improvements~~ Active share validation/authoritative mount improvements Feb 17, 2026

icewind1991 force-pushed the share-update-check-single branch 3 times, most recently from f29cc31 to 4b00db9 Compare February 18, 2026 16:00

icewind1991 requested a review from CarlSchwan February 18, 2026 16:30

artonge reviewed Feb 18, 2026

View reviewed changes

apps/files_sharing/lib/Config/ConfigLexicon.php Outdated Show resolved Hide resolved

apps/files_sharing/lib/Listener/SharesUpdatedListener.php Outdated Show resolved Hide resolved

provokateurin reviewed Feb 19, 2026

View reviewed changes

artonge reviewed Feb 20, 2026

View reviewed changes

icewind1991 force-pushed the share-update-check-single branch from 4b00db9 to 4c18fc1 Compare February 20, 2026 17:13

artonge reviewed Feb 20, 2026

View reviewed changes

icewind1991 added 12 commits February 24, 2026 20:10

fix: only validate mounts for new share

acba831

Signed-off-by: Robin Appelman <robin@icewind.nl>

feat: add event for user home mount having being setup

4c95214

Signed-off-by: Robin Appelman <robin@icewind.nl>

chore: move share recipient validation logic to a separate class

2fef6c2

Signed-off-by: Robin Appelman <robin@icewind.nl>

feat: postpone receiving share validation after processing a certain …

a21103f

…number of users Signed-off-by: Robin Appelman <robin@icewind.nl>

test: add test for delayed share validate

e683d47

Signed-off-by: Robin Appelman <robin@icewind.nl>

fix: disable share resolve postpone in tests

794cc28

Signed-off-by: Robin Appelman <robin@icewind.nl>

feat: export getData for public FileInfo interface

81fc3a3

Signed-off-by: Robin Appelman <robin@icewind.nl>

fix: clear in-memory cached mounts for user when adding/removing mounts

8c405f1

Signed-off-by: Robin Appelman <robin@icewind.nl>

test: add reusable mock implementation for IAppConfig

7fd2bab

Signed-off-by: Robin Appelman <robin@icewind.nl>

test: add reusable mock implementation for IUserConfig

22c2af3

Signed-off-by: Robin Appelman <robin@icewind.nl>

test: add some tests for SharesUpdatedListenerTest

4e03742

Signed-off-by: Robin Appelman <robin@icewind.nl>

test: add some tests for ShareRecipientUpdaterTest

025f9ee

Signed-off-by: Robin Appelman <robin@icewind.nl>

icewind1991 force-pushed the share-update-check-single branch 2 times, most recently from 61b9ed5 to 356d8f8 Compare February 25, 2026 15:40

icewind1991 added 2 commits February 25, 2026 16:56

feat: use time-based cutoff for share updating instead of count

a66c792

Signed-off-by: Robin Appelman <robin@icewind.nl>

fix: improve performance of handling delete shares

4de187a

Signed-off-by: Robin Appelman <robin@icewind.nl>

icewind1991 force-pushed the share-update-check-single branch from 356d8f8 to 4de187a Compare February 25, 2026 15:56

icewind1991 added 3 commits February 25, 2026 18:19

feat: add output options and '--cached-only' to list mounts command

5fecb00

Signed-off-by: Robin Appelman <robin@icewind.nl>

fix: update shares on group delete

207fc97

Signed-off-by: Robin Appelman <robin@icewind.nl>

test: add more integration tests for share mount handling

0a8ad13

Signed-off-by: Robin Appelman <robin@icewind.nl>

icewind1991 marked this pull request as ready for review February 25, 2026 19:56

icewind1991 requested review from artonge and provokateurin February 25, 2026 19:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Active share validation/authoritative mount improvements#57760

Active share validation/authoritative mount improvements#57760
icewind1991 wants to merge 17 commits intomasterfrom
share-update-check-single

icewind1991 commented Jan 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

provokateurin left a comment

Uh oh!

Uh oh!

provokateurin Feb 19, 2026

Uh oh!

icewind1991 Feb 20, 2026

Uh oh!

artonge Feb 20, 2026

Uh oh!

icewind1991 Feb 20, 2026

Uh oh!

artonge Feb 20, 2026

Uh oh!

Uh oh!

artonge Feb 20, 2026 •

edited

Loading

Uh oh!

icewind1991 Feb 23, 2026

Uh oh!

icewind1991 Feb 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		$shares = $this->shareMountProvider->getSuperSharesForUser($user, $ignoreShares);

		$mountsChanged = count($shares) !== count($shareMounts);

	if ($this->cutOffMarkTime === -1.0 \|\| $this->updatedTime < $this->cutOffMarkTime) {
	if ($this->cutOffMarkTime === -1.0 \|\| $this->updatedTime <= $this->cutOffMarkTime) {

Uh oh!

Conversation

icewind1991 commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

provokateurin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

provokateurin Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

icewind1991 Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

artonge Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

icewind1991 Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

artonge Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

artonge Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

icewind1991 Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

icewind1991 Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

icewind1991 commented Jan 23, 2026 •

edited

Loading

artonge Feb 20, 2026 •

edited

Loading