refactor(wopi): postFile override handling into helpers and streamline logic#5621
Open
joshtrichards wants to merge 4 commits intomainfrom
Open
refactor(wopi): postFile override handling into helpers and streamline logic#5621joshtrichards wants to merge 4 commits intomainfrom
joshtrichards wants to merge 4 commits intomainfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
weird Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
WopiController::postFile()to make WOPI override handling easier to follow by separating the main branches into focused helper methods for:RenameFilePutRelativeFileThis turns
postFile()into a clearer orchestrator and reduces the amount of mixed logic in the main controller method.Notes
RenameFileandPutRelativeFilepaths isolatedHTTP_BAD_REQUESTfor unsupported WOPI override valuesRenameFileresponse shape so it no longer matchesPutRelativeFileThe newly introduced
resolveWopiWriteContext()helper can be used for future refactoring the various other WOPI operations handling paths in this class, eliminating a lot of boilerplate/duplication.TODO
Checklist