refactor(Wopi): drop unused PUT_RELATIVE branch from putFile()#5620
Open
joshtrichards wants to merge 1 commit intomainfrom
Open
refactor(Wopi): drop unused PUT_RELATIVE branch from putFile()#5620joshtrichards wants to merge 1 commit intomainfrom
joshtrichards wants to merge 1 commit intomainfrom
Conversation
PUT_RELATIVE is never accessed via this endpoint. It is already handled via postFile()'s else branch. Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PutRelativeFile/PUT_RELATIVE) file operation? #5614Summary
The code for
PUT_RELATIVEinputFile()(which implements thePOST /wopi/files/{fileId}/contentsendpoint) is dead code. This file operation is never accessed via thecontentsendpoint. It is already handled via postFile()'s default/else branch on thePOST /wopi/files/{fileId}endpoint.Besides being dead code, having this non-spec alternative path around is confusing and dangerous since there is support for that override on the appropriate endpoint and the logic is a big different.
Already confirmed that Collabora Online uses the correct WOPI-compliant endpoint per it's code.
Change extracted from other refactoring work.
TODO
Checklist