refactor(Helper,TokenManager): migrate guest cookie access to IRequest add typing throughout#5602
Open
joshtrichards wants to merge 12 commits intomainfrom
Open
refactor(Helper,TokenManager): migrate guest cookie access to IRequest add typing throughout#5602joshtrichards wants to merge 12 commits intomainfrom
joshtrichards wants to merge 12 commits intomainfrom
Conversation
Eliminates two unnecessary/undesirable things: (1) a external static helper method that was only called here and only once; (2) accessing global state and `$_COOKIE` directly. Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…ookies Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves guest-name cookie access off the
$_COOKIEsuperglobal and onto the injectedIRequestservice, and modernizesHelperandTokenManagerwith new typing/docs/etc.Changes
lib/Helper.phpdeclare(strict_types=1)?string $userId) and all method signaturesparseFileId(): cleaner logic, throw\InvalidArgumentExceptioninstead of\Exception(all call sites either already capture this via "catch-all"\Exceptionhandling or already let it bubble up so should be a non-issue) , addexplodelimit for correctness, add typed array shape to@returnpreg_replaceresult ingetNewFileName()to avoid silent failuregetGuestNameFromCookie()(moved toTokenManagerwhich was the only caller anyway)lib/TokenManager.phpIRequestvia constructorgetGuestNameFromCookie()here as a private method usingIRequest::getCookie()instead of$_COOKIEWopi,string,void)TODO
Checklist