fix(wopi): improve robustness and error handling in getUrlSrc#5327
Open
joshtrichards wants to merge 1 commit intomainfrom
Open
fix(wopi): improve robustness and error handling in getUrlSrc#5327joshtrichards wants to merge 1 commit intomainfrom
joshtrichards wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Member
Author
|
I guess we should decide whether we should throw a specific exception if the issue is merely that there isn't a matching app name -- or just an empty array and let callers check for that... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
getUrlSrc()method in the WOPI Parser to improve its robustness, maintainability, and readability:These changes improve reliability when parsing WOPI discovery responses and make troubleshooting easier.
TODO
Checklist