fix(SecureView): ensure shouldSecure() doesn't attempt to call fopen() on directories#5257
Open
joshtrichards wants to merge 3 commits intomainfrom
Open
fix(SecureView): ensure shouldSecure() doesn't attempt to call fopen() on directories#5257joshtrichards wants to merge 3 commits intomainfrom
shouldSecure() doesn't attempt to call fopen() on directories#5257joshtrichards wants to merge 3 commits intomainfrom
Conversation
…ecache update in shouldSecure() fix(richdocuments): robustly determine file/directory before forcing filecache update in shouldSecure() Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
bug
8 tasks
joshtrichards
requested review from
blizzz,
elzody and
juliusknorr
and removed request for
elzody and
juliusknorr
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve the
shouldSecure()method to reliably determine whether a path is a file or directory -- using both the filecache and storage API -- before attempting to open the path. This prevents unnecessary or erroneousfopen()calls on directories (especially in external storage), ensures filecache metadata is prepared for permission checks, and enhances stability and clarity when applying SecureView restrictions.Helps with nextcloud/server#57342 (and may even resolve it, though there may be additional things going on there - TBD; this improvement is useful either way).
Related: #5171
TODO
Checklist